contacts: Rate-limit GData photo requests and handle 404s.

chrome/browser/chromeos/gdata/gdata_contacts_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CONTACTS_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CONTACTS_SERVICE_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 50 matching lines @@
 class GDataContactsService : public GDataContactsServiceInterface {
  public:
   typedef base::Callback<std::string(const std::string&)>
       RewritePhotoUrlCallback;
 
   explicit GDataContactsService(Profile* profile);
   virtual ~GDataContactsService();
 
   GDataAuthService* auth_service_for_testing();
 
-  void set_max_simultaneous_photo_downloads_for_testing(int max_downloads) {
-    max_simultaneous_photo_downloads_ = max_downloads;
+  void set_max_photo_downloads_per_second_for_testing(int max_downloads) {
+    max_photo_downloads_per_second_ = max_downloads;
+  }
+  void set_photo_download_timer_interval_for_testing(base::TimeDelta interval) {
+    photo_download_timer_interval_ = interval;
   }
   void set_feed_url_for_testing(const GURL& url) {
     feed_url_for_testing_ = url;
   }
   void set_rewrite_photo_url_callback_for_testing(RewritePhotoUrlCallback cb) {
     rewrite_photo_url_callback_for_testing_ = cb;
   }
 
   // Overridden from GDataContactsServiceInterface:
   virtual void Initialize() OVERRIDE;
   virtual void DownloadContacts(SuccessCallback success_callback,
                                 FailureCallback failure_callback,
                                 const base::Time& min_update_time) OVERRIDE;
 
  private:
   class DownloadContactsRequest;
 
   // Invoked by a download request once it's finished (either successfully or
   // unsuccessfully).
   void OnRequestComplete(DownloadContactsRequest* request);
 
   Profile* profile_;  // not owned
 
   scoped_ptr<GDataOperationRunner> runner_;
 
   // In-progress download requests.  Pointers are owned by this class.
   std::set<DownloadContactsRequest*> requests_;
 
+  // Maximum number of photos we'll try to download per second (per
+  // DownloadContacts() request).
+  int max_photo_downloads_per_second_;
+
+  // Amount of time that we'll wait between waves of photo download requests.
+  // This is usually one second (see |max_photo_downloads_per_second_|) but can
+  // be set to a lower value for tests to make them complete more quickly.
+  base::TimeDelta photo_download_timer_interval_;
+
   // If non-empty, URL that will be used to fetch the feed.  URLs contained
   // within the feed will also be modified to use the host and port from this
   // member.
   GURL feed_url_for_testing_;
 
-  // Maximum number of photos we'll try to download at once (per
-  // DownloadContacts() request).
-  int max_simultaneous_photo_downloads_;
-
   // Callback that's invoked to rewrite photo URLs for tests.
   // This is needed for tests that serve static feed data from a host/port
   // that's only known at runtime.
   RewritePhotoUrlCallback rewrite_photo_url_callback_for_testing_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataContactsService);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CONTACTS_SERVICE_H_