Cocoa: Support constrained windows for platform apps

chrome/browser/ui/cocoa/constrained_window_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/constrained_window_mac.h"
 
-#import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/constrained_window_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #import "third_party/GTM/AppKit/GTMWindowSheetController.h"
 
 ConstrainedWindowMacDelegateSystemSheet::
 ConstrainedWindowMacDelegateSystemSheet(id delegate, SEL didEndSelector)
     : systemSheet_(nil),
       delegate_([delegate retain]),
@@ skipping 80 matching lines @@
   tab_contents->constrained_window_tab_helper()->AddConstrainedDialog(this);
 }
 
 ConstrainedWindowMac::~ConstrainedWindowMac() {}
 
 void ConstrainedWindowMac::ShowConstrainedWindow() {
   should_be_visible_ = true;
   // The WebContents only has a native window if it is currently visible. In
   // this case, open the sheet now. Else, Realize() will be called later, when
   // our tab becomes visible.
-  NSWindow* browserWindow =
+  NSWindow* window =
       tab_contents_->web_contents()->GetView()->GetTopLevelNativeWindow();
-  BrowserWindowController* browser_controller =
-      [BrowserWindowController browserWindowControllerForWindow:browserWindow];
-  if ([browser_controller canAttachConstrainedWindow])
-    Realize(browser_controller);
+  NSWindowController<ConstrainedWindowSupport>* window_controller = nil;
+  while (window) {
+    if ([[window windowController] conformsToProtocol:
+        @protocol(ConstrainedWindowSupport)]) {

[Robert Sesek, 2012/08/06 22:18:34]

nit: indent4 from here

[sail, 2012/08/09 00:25:54]

Done.

+      window_controller = [window windowController];
+      break;
+    }
+    window = [window parentWindow];

[jeremya, 2012/08/05 22:32:47]

If the window is the TopLevelNativeWindow, will it have a parent?

[sail, 2012/08/09 00:25:54]

No, the parent will be nil.

[jeremya, 2012/08/09 00:32:48]

Then why check here? if [window parentWindow] is always nil, there's no need for
the loop, right?

[sail, 2012/08/09 00:40:42]

The idea is that we want the window controller of the top most window.

For example, if this window is a bubble, then we get the window controller of
the window hosting the bubble.

+  }
+
+  DCHECK(window_controller);

[jeremya, 2012/08/05 22:32:47]

Are we guaranteed a controller that conforms to ConstrainedWindowSupport?
Perhaps it would be better to bail out here if window_controller is nil. (I'm
thinking of panels and HTML notifications.)

[Robert Sesek, 2012/08/06 22:18:34]

That'll happen with the if-check below because you'd be sending a message to
nil.

+  if ([window_controller canAttachConstrainedWindow])
+    Realize(window_controller);
 }
 
 void ConstrainedWindowMac::CloseConstrainedWindow() {
   // Protection against reentrancy, which might otherwise become a problem if
   // DeleteDelegate forcibly closes a constrained window in a way that results
   // in CloseConstrainedWindow being called again.
   if (closing_)
     return;
 
   closing_ = true;
 
   // Note: controller_ can be `nil` here if the sheet was never realized. That's
   // ok.
   [controller_ removeConstrainedWindow:this];
   delegate_->DeleteDelegate();
   tab_contents_->constrained_window_tab_helper()->WillClose(this);
 
   delete this;
 }
 
-void ConstrainedWindowMac::Realize(BrowserWindowController* controller) {
+void ConstrainedWindowMac::Realize(
+    NSWindowController<ConstrainedWindowSupport>* controller) {
   if (!should_be_visible_)
     return;
 
   if (controller_ != nil) {
     DCHECK(controller_ == controller);
     return;
   }
   DCHECK(controller != nil);
 
   // Remember the controller we're adding ourselves to, so that we can later
   // remove us from it.
   controller_ = controller;
   [controller_ attachConstrainedWindow:this];
   delegate_->set_sheet_open(true);
 }