Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: media/base/audio_renderer_sink.h

Issue 10823175: Switch AudioRenderSink::Callback to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup MCR AudioBus usage. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_renderer_mixer_unittest.cc ('k') | media/base/fake_audio_render_callback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer_sink.h
diff --git a/media/base/audio_renderer_sink.h b/media/base/audio_renderer_sink.h
index 8786fe1826634c890643e386c57a83c934f53171..c5f43df3a5ccaef56138744b4ee08ba26193ff69 100644
--- a/media/base/audio_renderer_sink.h
+++ b/media/base/audio_renderer_sink.h
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
#include "media/audio/audio_parameters.h"
+#include "media/base/audio_bus.h"
#include "media/base/media_export.h"
namespace media {
@@ -22,14 +23,9 @@ class AudioRendererSink
public:
class RenderCallback {
public:
- // Fills entire buffer of length |number_of_frames| but returns actual
- // number of frames it got from its source (|number_of_frames| in case of
- // continuous stream). That actual number of frames is passed to host
- // together with PCM audio data and host is free to use or ignore it.
- // TODO(crogers): use base:Callback instead.
- virtual int Render(const std::vector<float*>& audio_data,
- int number_of_frames,
- int audio_delay_milliseconds) = 0;
+ // Attempts to completely fill all channels of |audio_bus|, returns actual
+ // number of frames filled.
+ virtual int Render(AudioBus* audio_bus, int audio_delay_milliseconds) = 0;
// Signals an error has occurred.
virtual void OnRenderError() = 0;
« no previous file with comments | « media/base/audio_renderer_mixer_unittest.cc ('k') | media/base/fake_audio_render_callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698