Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: media/base/audio_renderer_mixer.cc

Issue 10823175: Switch AudioRenderSink::Callback to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Gotta catch'em all! Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_renderer_mixer.cc
diff --git a/media/base/audio_renderer_mixer.cc b/media/base/audio_renderer_mixer.cc
index 1ca2f39f7f58d8cff456ba3c7623a974a8da870d..8340cf3c513a2cd18bbd7c57df6cfc475a533447 100644
--- a/media/base/audio_renderer_mixer.cc
+++ b/media/base/audio_renderer_mixer.cc
@@ -46,11 +46,6 @@ AudioRendererMixer::~AudioRendererMixer() {
// AudioRendererSinks must be stopped before being destructed.
audio_sink_->Stop();
- // Clean up |mixer_input_audio_data_|.
- for (size_t i = 0; i < mixer_input_audio_data_.size(); ++i)
- base::AlignedFree(mixer_input_audio_data_[i]);
- mixer_input_audio_data_.clear();
-
// Ensures that all mixer inputs have stopped themselves prior to destruction
// and have called RemoveMixerInput().
DCHECK_EQ(mixer_inputs_.size(), 0U);
@@ -68,45 +63,40 @@ void AudioRendererMixer::RemoveMixerInput(
mixer_inputs_.erase(input);
}
-int AudioRendererMixer::Render(const std::vector<float*>& audio_data,
+int AudioRendererMixer::Render(AudioBus* audio_bus,
int number_of_frames,
int audio_delay_milliseconds) {
current_audio_delay_milliseconds_ = audio_delay_milliseconds;
if (resampler_.get())
- resampler_->Resample(audio_data, number_of_frames);
+ resampler_->Resample(audio_bus, number_of_frames);
else
- ProvideInput(audio_data, number_of_frames);
+ ProvideInput(audio_bus, number_of_frames);
// Always return the full number of frames requested, ProvideInput() will pad
// with silence if it wasn't able to acquire enough data.
return number_of_frames;
}
-void AudioRendererMixer::ProvideInput(const std::vector<float*>& audio_data,
+void AudioRendererMixer::ProvideInput(AudioBus* audio_bus,
int number_of_frames) {
base::AutoLock auto_lock(mixer_inputs_lock_);
// Allocate staging area for each mixer input's audio data on first call. We
// won't know how much to allocate until here because of resampling.
- if (mixer_input_audio_data_.size() == 0) {
- mixer_input_audio_data_.reserve(audio_data.size());
- for (size_t i = 0; i < audio_data.size(); ++i) {
- // Allocate audio data with a 16-byte alignment for SSE optimizations.
- mixer_input_audio_data_.push_back(static_cast<float*>(
- base::AlignedAlloc(sizeof(float) * number_of_frames, 16)));
- }
- mixer_input_audio_data_size_ = number_of_frames;
+ if (!mixer_input_audio_bus_.get()) {
+ mixer_input_audio_bus_ =
+ AudioBus::Create(audio_bus->channels(), number_of_frames);
}
// Sanity check our inputs.
- DCHECK_LE(number_of_frames, mixer_input_audio_data_size_);
- DCHECK_EQ(audio_data.size(), mixer_input_audio_data_.size());
+ DCHECK_LE(number_of_frames, audio_bus->frames());
+ DCHECK_LE(number_of_frames, mixer_input_audio_bus_->frames());
+ DCHECK_EQ(audio_bus->channels(), mixer_input_audio_bus_->channels());
- // Zero |audio_data| so we're mixing into a clean buffer and return silence if
+ // Zero |audio_bus| so we're mixing into a clean buffer and return silence if
// we couldn't get enough data from our inputs.
- for (size_t i = 0; i < audio_data.size(); ++i)
- memset(audio_data[i], 0, number_of_frames * sizeof(*audio_data[i]));
+ audio_bus->ZeroFrames(number_of_frames);
// Have each mixer render its data into an output buffer then mix the result.
for (AudioRendererMixerInputSet::iterator it = mixer_inputs_.begin();
@@ -121,15 +111,15 @@ void AudioRendererMixer::ProvideInput(const std::vector<float*>& audio_data,
continue;
int frames_filled = input->callback()->Render(
- mixer_input_audio_data_, number_of_frames,
+ mixer_input_audio_bus_.get(), number_of_frames,
current_audio_delay_milliseconds_);
if (frames_filled == 0)
continue;
- // Volume adjust and mix each mixer input into |audio_data| after rendering.
- for (size_t j = 0; j < audio_data.size(); ++j) {
- VectorFMAC(
- mixer_input_audio_data_[j], volume, frames_filled, audio_data[j]);
+ // Volume adjust and mix each mixer input into |audio_bus| after rendering.
+ for (int i = 0; i < audio_bus->channels(); ++i) {
+ VectorFMAC(mixer_input_audio_bus_->channel(i), volume, frames_filled,
+ audio_bus->channel(i));
}
// No need to clamp values as InterleaveFloatToInt() will take care of this

Powered by Google App Engine
This is Rietveld 408576698