Add path filtering to DeviceMediaFileUtil

webkit/fileapi/media/device_media_file_util.cc

Index: webkit/fileapi/media/device_media_file_util.cc
diff --git a/webkit/fileapi/media/device_media_file_util.cc b/webkit/fileapi/media/device_media_file_util.cc
index 37b04a9061521f89401aeb42d50999e2eb73eea1..5d7968df84593734a66a26794777cc91b57e44df 100644
--- a/webkit/fileapi/media/device_media_file_util.cc
+++ b/webkit/fileapi/media/device_media_file_util.cc
@@ -11,8 +11,10 @@
 #include "webkit/fileapi/file_system_operation_context.h"
 #include "webkit/fileapi/file_system_url.h"
 #include "webkit/fileapi/isolated_context.h"
+#include "webkit/fileapi/media/filtering_file_enumerator.h"
 #include "webkit/fileapi/media/media_device_interface_impl.h"
 #include "webkit/fileapi/media/media_device_map_service.h"
+#include "webkit/fileapi/media/media_path_filter.h"
 
 using base::PlatformFileError;
 using base::PlatformFileInfo;
@@ -67,7 +69,15 @@ PlatformFileError DeviceMediaFileUtil::GetFileInfo(
     FilePath* platform_path) {
   if (!context->media_device())
     return base::PLATFORM_FILE_ERROR_NOT_FOUND;
-  return context->media_device()->GetFileInfo(url.path(), file_info);
+  PlatformFileError error =
+      context->media_device()->GetFileInfo(url.path(), file_info);
+  if (error != base::PLATFORM_FILE_OK)
+      return error;
+
+  if (file_info->is_directory ||
+      context->media_path_filter()->Match(url.path()))
+    return base::PLATFORM_FILE_OK;
+  return base::PLATFORM_FILE_ERROR_NOT_FOUND;
 }
 
 FileSystemFileUtil::AbstractFileEnumerator*
@@ -77,7 +87,10 @@ DeviceMediaFileUtil::CreateFileEnumerator(
     bool recursive) {
   if (!context->media_device())
     return new FileSystemFileUtil::EmptyFileEnumerator();
-  return context->media_device()->CreateFileEnumerator(url.path(), recursive);
+  return new FilteringFileEnumerator(
+      make_scoped_ptr(
+          context->media_device()->CreateFileEnumerator(url.path(), recursive)),
+      context->media_path_filter());
 }
 
 PlatformFileError DeviceMediaFileUtil::GetLocalFilePath(
@@ -110,7 +123,12 @@ bool DeviceMediaFileUtil::PathExists(
     const FileSystemURL& url) {
   if (!context->media_device())
     return false;
-  return context->media_device()->PathExists(url.path());
+
+  FilePath path;
+  PlatformFileInfo file_info;
+  PlatformFileError error =
+      GetFileInfo(context, url, &file_info, &path);

[kmadhusu, 2012/08/03 23:58:47]

nit: Try to fit as much as possible in line 129.

[tzik, 2012/08/04 01:00:42]

Done.

+  return error == base::PLATFORM_FILE_OK;
 }
 
 bool DeviceMediaFileUtil::DirectoryExists(
@@ -126,7 +144,16 @@ bool DeviceMediaFileUtil::IsDirectoryEmpty(
     const FileSystemURL& url) {
   if (!context->media_device())
     return false;
-  return context->media_device()->IsDirectoryEmpty(url.path());
+
+  scoped_ptr<AbstractFileEnumerator> enumerator(
+      CreateFileEnumerator(context, url, false));
+  FilePath path;
+  while (!(path = enumerator->Next()).empty()) {
+    if (enumerator->IsDirectory() ||
+        context->media_path_filter()->Match(path))
+      return false;
+  }
+  return true;
 }
 
 PlatformFileError DeviceMediaFileUtil::CopyOrMoveFile(