Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823171: Add path filtering to DeviceMediaFileUtil (Closed)

Created:
8 years, 4 months ago by tzik
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Add path filtering to DeviceMediaFileUtil BUG=137670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150183

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : build fix #

Total comments: 2

Patch Set 5 : build fix #

Total comments: 6

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : buildfix for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -53 lines) Patch
M webkit/fileapi/media/device_media_file_util.cc View 1 2 3 4 5 6 7 5 chunks +30 lines, -4 lines 0 comments Download
A webkit/fileapi/media/filtering_file_enumerator.h View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/fileapi/media/filtering_file_enumerator.cc View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M webkit/fileapi/media/native_media_file_util.cc View 8 chunks +7 lines, -49 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tzik
Could you take a look? Applying MediaPathFilter to DeviceMediaFileUtil.
8 years, 4 months ago (2012-08-03 23:23:04 UTC) #1
kinuko
On 2012/08/03 23:23:04, tzik wrote: > Could you take a look? > Applying MediaPathFilter to ...
8 years, 4 months ago (2012-08-03 23:28:10 UTC) #2
kmadhusu
http://codereview.chromium.org/10823171/diff/9002/webkit/fileapi/media/device_media_file_util.cc File webkit/fileapi/media/device_media_file_util.cc (right): http://codereview.chromium.org/10823171/diff/9002/webkit/fileapi/media/device_media_file_util.cc#newcode75 webkit/fileapi/media/device_media_file_util.cc:75: return error; nit: fix intent. http://codereview.chromium.org/10823171/diff/7003/webkit/fileapi/media/device_media_file_util.cc File webkit/fileapi/media/device_media_file_util.cc (right): ...
8 years, 4 months ago (2012-08-03 23:58:47 UTC) #3
tzik
http://codereview.chromium.org/10823171/diff/9002/webkit/fileapi/media/device_media_file_util.cc File webkit/fileapi/media/device_media_file_util.cc (right): http://codereview.chromium.org/10823171/diff/9002/webkit/fileapi/media/device_media_file_util.cc#newcode75 webkit/fileapi/media/device_media_file_util.cc:75: return error; On 2012/08/03 23:58:47, kmadhusu wrote: > nit: ...
8 years, 4 months ago (2012-08-04 01:00:42 UTC) #4
kmadhusu
lgtm
8 years, 4 months ago (2012-08-04 01:18:46 UTC) #5
kinuko
lgtm, but in general having filter->Match() scattered in multiple files doesn't feel really great to ...
8 years, 4 months ago (2012-08-06 18:32:05 UTC) #6
tzik
On 2012/08/06 18:32:05, kinuko wrote: > lgtm, but in general having filter->Match() scattered in multiple ...
8 years, 4 months ago (2012-08-06 18:51:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10823171/6003
8 years, 4 months ago (2012-08-06 18:51:46 UTC) #8
commit-bot: I haz the power
Try job failure for 10823171-6003 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 20:05:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10823171/6006
8 years, 4 months ago (2012-08-06 20:08:46 UTC) #10
commit-bot: I haz the power
Try job failure for 10823171-6006 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 20:39:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10823171/6006
8 years, 4 months ago (2012-08-06 20:42:38 UTC) #12
commit-bot: I haz the power
Try job failure for 10823171-6006 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=50110 Step "update" is always ...
8 years, 4 months ago (2012-08-06 21:58:54 UTC) #13
tzik
On 2012/08/06 21:58:54, I haz the power (commit-bot) wrote: > Try job failure for 10823171-6006 ...
8 years, 4 months ago (2012-08-06 22:08:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10823171/6006
8 years, 4 months ago (2012-08-06 22:09:33 UTC) #15
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 22:55:48 UTC) #16 
Try job failure for 10823171-6006 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698