chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 10823169: Another attempt at fixing dead frames being tracked by webNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 10823169: Another attempt at fixing dead frames being tracked by webNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index 5c5f3c4ab4ebb159ccdcf79dfabf3c76643f8ba8..7f5868e3be7de5559c62fa2cd293721602bfc0cb 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -113,7 +113,11 @@ class WebNavigationTabObserver : public content::NotificationObserver,

// Used for tracking registrations to redirect notifications.

content::NotificationRegistrar registrar_;

+ // The current RenderViewHost of the observed WebContents.

content::RenderViewHost* render_view_host_;

+ // During a cross site navigation, the WebContents has a second, pending

+ // RenderViewHost.

content::RenderViewHost* pending_render_view_host_;

DISALLOW_COPY_AND_ASSIGN(WebNavigationTabObserver);