chrome/test/data/extensions/api_test/webnavigation/app/manifest.json - Issue 10823169: Another attempt at fixing dead frames being tracked by webNavigation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/webnavigation/app/manifest.json

Issue 10823169: Another attempt at fixing dead frames being tracked by webNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('K') | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/test/data/extensions/api_test/webnavigation/crossProcess/a.html » ('j') | chrome/test/data/extensions/api_test/webnavigation/crossProcess/b.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "App Test",

	3 "version": "1",

	4 "manifest_version": 2,

	5 "permissions": [

	6 "background"

	7 ],

	8 "app": {

	9 "launch": {

	10 "web_url": "http://www.a.com/"

	11 },

	12 "urls": [

	13 "http://www.a.com/server-redirect"
	Charlie Reis 2012/08/06 20:04:13 Why is this the web extent for the app? It doesn' Why is this the web extent for the app? It doesn't include the launch URL, which should be illegal (http://crbug.com/106123). jochen (gone - plz use gerrit) 2012/08/06 21:08:39 I made this the launch URL. Show quoted text On 2012/08/06 20:04:13, creis wrote: > Why is this the web extent for the app? It doesn't include the launch URL, > which should be illegal (http://crbug.com/106123). I made this the launch URL. Charlie Reis 2012/08/06 21:30:26 Now there's no extent, so we'll never enter the ap Show quoted text On 2012/08/06 21:08:39, jochen wrote: > On 2012/08/06 20:04:13, creis wrote: > > Why is this the web extent for the app? It doesn't include the launch URL, > > which should be illegal (http://crbug.com/106123). > > I made this the launch URL. Now there's no extent, so we'll never enter the app's process. I think you just had them reversed. The extent should probably be http://www.a.com, right? jochen (gone - plz use gerrit) 2012/08/06 21:42:32 Without an extent, the launch url's host + /* is u Show quoted text On 2012/08/06 21:30:26, creis wrote: > On 2012/08/06 21:08:39, jochen wrote: > > On 2012/08/06 20:04:13, creis wrote: > > > Why is this the web extent for the app? It doesn't include the launch URL, > > > which should be illegal (http://crbug.com/106123). > > > > I made this the launch URL. > > Now there's no extent, so we'll never enter the app's process. I think you just > had them reversed. The extent should probably be http://www.a.com, right? Without an extent, the launch url's host + /* is used as web extent by default
	14 ]

	15 }

	16 }

OLD	NEW