Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823156: Fix live bug & renable ChunkDemuxerTest.TestWebMFile_LiveAudioAndVideo (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix live bug & renable ChunkDemuxerTest.TestWebMFile_LiveAudioAndVideo BUG=136438 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149788

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address CR comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M media/filters/chunk_demuxer_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M media/webm/webm_cluster_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
acolwell GONE FROM CHROMIUM
Trivial fix for live content. Content file is updated here. http://codereview.chromium.org/10830155/
8 years, 4 months ago (2012-08-03 00:37:07 UTC) #1
vrk (LEFT CHROMIUM)
LGTM http://codereview.chromium.org/10823156/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): http://codereview.chromium.org/10823156/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode1217 media/filters/chunk_demuxer_unittest.cc:1217: // keyframes and reenable test. (crbug.com/136438) nit: delete ...
8 years, 4 months ago (2012-08-03 00:39:22 UTC) #2
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/10823156/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): http://codereview.chromium.org/10823156/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode1217 media/filters/chunk_demuxer_unittest.cc:1217: // keyframes and reenable test. (crbug.com/136438) On 2012/08/03 00:39:22, ...
8 years, 4 months ago (2012-08-03 00:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10823156/4
8 years, 4 months ago (2012-08-03 01:02:24 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 02:40:46 UTC) #5 
Change committed as 149788

Powered by Google App Engine
This is Rietveld 408576698