Support reverse conversion for ChromeOS

Support reverse conversion for ChromeOS

This cl does not support fully surrounding text retrieval, but it is enough to send selection text for reverse conversion.

I will revisit fully SetSurroundingText implementation when it is required.

BUG=127032
TEST=ran content_unittests, ui_unittests, chromeos_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149824

[Seigo Nonaka, 2012-08-02 18:39:05]

Yusuke:
Sorry, I revised this CL to be more simple.
This CL is not urgent, but please take a look.

Thank you.

[Yusuke Sato, 2012-08-03 05:46:10]

LGTM

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.cc (right):

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:359: string16 selection_text;
nit: move to L.366

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:378: // but currently there are no way to
retrieve surrdounding text in
surrounding

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:382: 0UL,
is this a caret pos? add /* parameter_name */

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:384: LOG(ERROR) << selection_text;
remove

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.h (right):

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.h:212: string16 previous_selected_text_;
nit: selected_text_ would be clear enough to me.

[Seigo Nonaka, 2012-08-03 07:12:44]

Thank you for your review! I will submit after check try bots just in case.

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.cc (right):

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:359: string16 selection_text;
On 2012/08/03 05:46:10, Yusuke Sato wrote:
> nit: move to L.366

Done.

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:378: // but currently there are no way to
retrieve surrdounding text in
On 2012/08/03 05:46:10, Yusuke Sato wrote:
> surrounding

Done.

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:382: 0UL,
On 2012/08/03 05:46:10, Yusuke Sato wrote:
> is this a caret pos? add /* parameter_name */

Done.

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:384: LOG(ERROR) << selection_text;
On 2012/08/03 05:46:10, Yusuke Sato wrote:
> remove

Done.

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.h (right):

http://codereview.chromium.org/10823141/diff/9001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.h:212: string16 previous_selected_text_;
Sure, removed.
On 2012/08/03 05:46:10, Yusuke Sato wrote:
> nit: selected_text_ would be clear enough to me.

[commit-bot: I haz the power, 2012-08-03 08:04:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10823141/13001

[commit-bot: I haz the power, 2012-08-03 09:30:01]

Change committed as 149824