skia expects to be initialized before it can be used. This must be done if serializing SkPicture, w…

content/renderer/gpu/gpu_benchmarking_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
 
 #include <string>
 
+#include "base/at_exit.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/string_number_conversions.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/renderer/all_rendering_benchmarks.h"
 #include "content/renderer/render_view_impl.h"
 #include "content/renderer/rendering_benchmark.h"
 #include "content/renderer/rendering_benchmark_results.h"
+#include "third_party/skia/include/core/SkGraphics.h"
 #include "third_party/skia/include/core/SkPicture.h"
 #include "third_party/skia/include/core/SkStream.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebRenderingStats.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h"
 #include "v8/include/v8.h"
 
 using WebKit::WebCanvas;
 using WebKit::WebFrame;
 using WebKit::WebPrivatePtr;
 using WebKit::WebRenderingStats;
 using WebKit::WebSize;
 using WebKit::WebView;
 using WebKit::WebViewBenchmarkSupport;
 
 const char kGpuBenchmarkingExtensionName[] = "v8/GpuBenchmarking";
 
 namespace {
 
+void TermSkGraphics(void* /* unused */) {
+  SkGraphics::Term();

[jamesr, 2012/08/07 20:51:26]

this doesn't appear to actually be related to SkGraphics::Init() at all, based
on the comment.  What does it do?  Do you need to do anything at process
termination?  Keep in mind that in many cases we won't call this at all when
terminating a renderer, so you can't rely on anything being called in here for
correctness.  If you don't need it, I would strongly prefer not bothering with
it - AtExitManager stuff is almost always more trouble than it's worth.

The current implementation just calls PurgeFontCache().  I can't think of any
reason why we would want to purge the font cache if we're about to exit the
process anyway.

[reed1, 2012/08/07 21:14:52]

Term() is useful if you're tracking memory leaks, but it is never required for
correctness.

+}
+
+void InitSkGraphics() {
+  static bool init = false;
+  if (!init) {

[jamesr, 2012/08/07 20:51:26]

do we only ever call this from one thread?

[alokp, 2012/08/08 17:24:34]

Yes - added comment.

+    SkGraphics::Init();
+    base::AtExitManager::RegisterCallback(TermSkGraphics, NULL);
+    init = true;
+  }
+}
+
 class SkPictureRecorder : public WebViewBenchmarkSupport::PaintClient {
  public:
   explicit SkPictureRecorder(const FilePath& dirpath)
       : dirpath_(dirpath),
         layer_id_(0) {
+    // Let skia register known effect subclasses. This basically enables
+    // reflection on those subclasses required for picture serialization.
+    InitSkGraphics();
   }
 
   virtual WebCanvas* willPaint(const WebSize& size) {
     return picture_.beginRecording(size.width, size.height);
   }
 
   virtual void didPaint(WebCanvas* canvas) {
     DCHECK(canvas == picture_.getRecordingCanvas());
     picture_.endRecording();
     // Serialize picture to file.
@@ skipping 241 matching lines @@
 
     return results.results_array();
   }
 };
 
 v8::Extension* GpuBenchmarkingExtension::Get() {
   return new GpuBenchmarkingWrapper();
 }
 
 }  // namespace content