crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher

crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher

CrOS Aura: Fix pinning Chrome Web Store to Launcher

Added two icon filenames to the manifest for the Chrome Web Store.
Created subdir "images" where manifest resides and copied two
appropriate icons.

More detail:
The "icons" element in the manifest for the Chrome Web Store was empty.
This seem to cause  the DCHECK failure when trying to pin the CWS to
the Launcher.
Adding two icon filenames to the manifest fixed the issue. I believe
the actual icons being used come from somewhere else.

BUG=124865
TEST=Click on Apps icon in the Launcher;
     Right click on Chrome Web Store;
     Select Pin to Launcher;
     Observe no DCHECK on Debug build on linux desktop

[Aaron Boodman, 2012-08-01 11:43:44]

Can you also remove the duplicate icons elsewhere in the source tree and the
places that reference them to get them from this extension instead?

[Aaron Boodman, 2012-08-01 11:45:30]

+davemoore

Actually, now that I think about it, it is also incorrect for the launcher to
DCHECK that icons are present. Icons are not required in extension or app
manifests. That code should fall back to the default extension or app icon if
the extension or app does not specify an icon.

[sschmitz, 2012-08-02 23:45:35]

On 2012/08/01 11:45:30, Aaron Boodman wrote:
> +davemoore
> 
> Actually, now that I think about it, it is also incorrect for the launcher to
> DCHECK that icons are present. Icons are not required in extension or app
> manifests. That code should fall back to the default extension or app icon if
> the extension or app does not specify an icon.

I'v abandoned this CL/issue.
It has been superseded by 10830123