net: disable SSL compression

chrome/browser/page_info_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_info_model.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 223 matching lines @@
         (ssl.connection_status &
         net::SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION) != 0;
     const char *key_exchange, *cipher, *mac;
     net::SSLCipherSuiteToStrings(&key_exchange, &cipher, &mac, cipher_suite);
 
     description += ASCIIToUTF16("\n\n");
     description += l10n_util::GetStringFUTF16(
         IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTION_DETAILS,
         ASCIIToUTF16(cipher), ASCIIToUTF16(mac), ASCIIToUTF16(key_exchange));
 
-    description += ASCIIToUTF16("\n\n");
     uint8 compression_id =
         net::SSLConnectionStatusToCompression(ssl.connection_status);
     if (compression_id) {
       const char* compression;
       net::SSLCompressionToString(&compression, compression_id);
+      description += ASCIIToUTF16("\n\n");
       description += l10n_util::GetStringFUTF16(
           IDS_PAGE_INFO_SECURITY_TAB_COMPRESSION_DETAILS,
           ASCIIToUTF16(compression));
-    } else {
-      description += l10n_util::GetStringUTF16(
-          IDS_PAGE_INFO_SECURITY_TAB_NO_COMPRESSION);

[wtc, 2012/08/01 17:31:28]

Just to doublecheck: if TLS compression is not used, you
don't want the page info model to say that.  Correct?

[agl, 2012/08/01 23:04:59]

Yes. It seems silly to mention that the connection is not compressed if we don't
support it. In the future we'll probably want to clean this up but I don't want
to make this patch hard to merge.

     }
 
     if (did_fallback) {
       // For now, only SSL/TLS version fallback will trigger a warning icon.
       if (icon_id < ICON_STATE_WARNING_MINOR)
         icon_id = ICON_STATE_WARNING_MINOR;
       description += ASCIIToUTF16("\n\n");
       description += l10n_util::GetStringUTF16(
           IDS_PAGE_INFO_SECURITY_TAB_FALLBACK_MESSAGE);
     }
@@ skipping 96 matching lines @@
   // Loads the icons into the vector. The order must match the SectionStateIcon
   // enum.
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PAGEINFO_GOOD));
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PAGEINFO_WARNING_MINOR));
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PAGEINFO_WARNING_MAJOR));
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PAGEINFO_BAD));
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PAGEINFO_INFO));
   icons_.push_back(&rb.GetNativeImageNamed(IDR_PRODUCT_LOGO_26));
 }