Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823109: Add ability to customise Virtual Me2Me X session. (Closed)

Created:
8 years, 4 months ago by Lambros
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add ability to customise Virtual Me2Me X session. This avoids the need for editing the script, which is impractical when it is installed from a Debian package. BUG=131245 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149551

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase, and change custom session filename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M remoting/tools/me2me_virtual_host.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lambros
8 years, 4 months ago (2012-07-31 21:00:31 UTC) #1
Jamie
lgtm http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py#newcode499 remoting/tools/me2me_virtual_host.py:499: shell = os.environ.get("SHELL", "sh") Optional: test for undefined ...
8 years, 4 months ago (2012-07-31 21:08:06 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py#newcode491 remoting/tools/me2me_virtual_host.py:491: startup_file = os.path.expanduser("~/.me2me_session") maybe call it .crd_session or .chrome_remoting_session? ...
8 years, 4 months ago (2012-07-31 21:09:41 UTC) #3
Lambros
http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10823109/diff/1/remoting/tools/me2me_virtual_host.py#newcode491 remoting/tools/me2me_virtual_host.py:491: startup_file = os.path.expanduser("~/.me2me_session") On 2012/07/31 21:09:41, sergeyu wrote: > ...
8 years, 4 months ago (2012-08-01 23:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10823109/1002
8 years, 4 months ago (2012-08-01 23:46:35 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 01:06:44 UTC) #6 
Change committed as 149551

Powered by Google App Engine
This is Rietveld 408576698