Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 10823093: [Android] Upstream changes to android_testrunner. (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Upstream changes to android_testrunner. 1. Add option to suppress logging to omit sensitive information. 2. Change debug output to longMsg to aid debugging. BUG=137853 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149204

Patch Set 1 #

Total comments: 2

Patch Set 2 : add docstring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M third_party/android_testrunner/README.chromium View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/android_testrunner/adb_interface.py View 1 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
8 years, 4 months ago (2012-07-31 00:35:16 UTC) #1
bulach
lgtm w/ nit: http://codereview.chromium.org/10823093/diff/1/third_party/android_testrunner/adb_interface.py File third_party/android_testrunner/adb_interface.py (right): http://codereview.chromium.org/10823093/diff/1/third_party/android_testrunner/adb_interface.py#newcode196 third_party/android_testrunner/adb_interface.py:196: instrumentation_args: Dictionary of key value bundle ...
8 years, 4 months ago (2012-07-31 10:31:06 UTC) #2
Yaron
http://codereview.chromium.org/10823093/diff/1/third_party/android_testrunner/adb_interface.py File third_party/android_testrunner/adb_interface.py (right): http://codereview.chromium.org/10823093/diff/1/third_party/android_testrunner/adb_interface.py#newcode196 third_party/android_testrunner/adb_interface.py:196: instrumentation_args: Dictionary of key value bundle arguments to pass ...
8 years, 4 months ago (2012-07-31 15:34:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10823093/4001
8 years, 4 months ago (2012-07-31 15:34:58 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 16:44:12 UTC) #5
Change committed as 149204

Powered by Google App Engine
This is Rietveld 408576698