Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: net/socket/ssl_socket.h

Issue 10823084: Add a new GetTlsUniqueChannelBinding method to SSLSocket, and implement nss version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_server_socket_nss.h ('K') | « net/socket/ssl_server_socket_nss.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_socket.h
diff --git a/net/socket/ssl_socket.h b/net/socket/ssl_socket.h
index bd063a425af7d10bdd77fb3bdf9c959f63e5980e..ff1fcc48a8d8514e51e7b588e073b256865ca093 100644
--- a/net/socket/ssl_socket.h
+++ b/net/socket/ssl_socket.h
@@ -27,6 +27,13 @@ public:
const base::StringPiece& context,
unsigned char* out,
unsigned int outlen) = 0;
+
+ // Returns the tls-unique channel bindings (see RFC 5929).
+ // At most, |outlen_max| bytes will be written to |out|. The
+ // actual number of bytes written will be set in |outlen|.
wtc 2012/07/30 20:05:08 Nit: remove the comma after "At most". Add '*' be
Ryan Hamilton 2012/07/30 21:37:58 Done.
+ virtual int GetTlsUniqueChannelBinding(unsigned char* out,
wtc 2012/07/30 20:05:08 Please spell "TLS" in all caps. History: our Styl
Ryan Hamilton 2012/07/30 21:37:58 Done.
+ unsigned int *outlen,
+ unsigned int outlen_max) = 0;
wtc 2012/07/30 20:05:08 We probably should just use a std::string* out o
Ryan Hamilton 2012/07/30 21:37:58 Done.
};
} // namespace net
« net/socket/ssl_server_socket_nss.h ('K') | « net/socket/ssl_server_socket_nss.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698