Throttle SelectRange IPC

content/browser/renderer_host/render_widget_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 
 #include <deque>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/process_util.h"
 #include "base/property_bag.h"
 #include "base/string16.h"
 #include "base/timer.h"
@@ skipping 478 matching lines @@
   void OnMsgPaintAtSizeAck(int tag, const gfx::Size& size);
   void OnCompositorSurfaceBuffersSwapped(int32 surface_id,
                                          uint64 surface_handle,
                                          int32 route_id,
                                          int32 gpu_process_host_id);
   void OnMsgUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
   void OnMsgUpdateIsDelayed();
   void OnMsgInputEventAck(WebKit::WebInputEvent::Type event_type,
                           bool processed);
   void OnMsgBeginSmoothScroll(bool scroll_down, bool scroll_far);
+  void OnMsgSelectRangeAck();
   virtual void OnMsgFocus();
   virtual void OnMsgBlur();
   void OnMsgHasTouchEventHandlers(bool has_handlers);
 
   void OnMsgSetCursor(const WebCursor& cursor);
   void OnMsgTextInputStateChanged(ui::TextInputType type,
                                   bool can_compose_inline);
   void OnMsgImeCompositionRangeChanged(
       const ui::Range& range,
       const std::vector<gfx::Rect>& character_bounds);
@@ skipping 161 matching lines @@
   // (Similar to |mouse_wheel_pending_|.). True if gesture event was sent and
   // we are waiting for a corresponding ack.
   bool gesture_event_pending_;
 
   typedef std::deque<WebKit::WebGestureEvent> GestureEventQueue;
 
   // (Similar to |coalesced_mouse_wheel_events_|.) GestureScrollUpdate events
   // are coalesced by merging deltas in a similar fashion as wheel events.
   GestureEventQueue coalesced_gesture_events_;
 
+  // (Similar to |mouse_move_pending_|.) True while waiting for SelectRange_ACK.
+  bool select_range_pending_;
+
+  // (Similar to |next_mouse_move_|.) The next SelectRange to send, if any.
+  scoped_ptr<std::pair<gfx::Point, gfx::Point> > next_select_range_;

[darin (slow to review), 2012/08/02 16:37:17]

Please just define a struct instead of using std::pair.  The usage of 'first'
and 'second' in code is rarely readable.

How about this:
  struct SelectionRange {
    gfx::Point start, end;
  };
  scoped_ptr<SelectionRange> next_selection_range_;

^^^ reads better to say that "SelectRange sends a selection range," which is why
I named the type SelectionRange instead of SelectRange.

[Iain Merrick, 2012/08/06 11:28:45]

Done.

+
   // The time when an input event was sent to the RenderWidget.
   base::TimeTicks input_event_start_time_;
 
   // Keyboard event listeners.
   std::list<KeyboardListener*> keyboard_listeners_;
 
   // If true, then we should repaint when restoring even if we have a
   // backingstore.  This flag is set to true if we receive a paint message
   // while is_hidden_ to true.  Even though we tell the render widget to hide
   // itself, a paint message could already be in flight at that point.
@@ skipping 79 matching lines @@
   scoped_ptr<TapSuppressionController> tap_suppression_controller_;
 
   scoped_ptr<SmoothScrollGesture> active_smooth_scroll_gesture_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_