content/browser/accessibility/dump_accessibility_tree_helper_win.cc - Issue 10823073: Improve accessible name calculation on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_helper_win.cc

Issue 10823073: Improve accessible name calculation on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_helper.cc ('k') | content/test/data/accessibility/button-name-calc.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_helper_win.cc

diff --git a/content/browser/accessibility/dump_accessibility_tree_helper_win.cc b/content/browser/accessibility/dump_accessibility_tree_helper_win.cc

index 6aae2becc2f19c6ba9213b50ed915bf828f10b90..df9ec76d9949cac28b91a641a72c38780ac53882 100644

--- a/content/browser/accessibility/dump_accessibility_tree_helper_win.cc

+++ b/content/browser/accessibility/dump_accessibility_tree_helper_win.cc

@@ -42,10 +42,12 @@ string16 DumpAccessibilityTreeHelper::ToString(

IAccessibleStateToStringVector(acc_obj->ia_state(), &state_strings);

IAccessible2StateToStringVector(acc_obj->ia2_state(), &state_strings);

- // Get the description and attributes.

+ // Get the description, help, and attributes.

string16 description;

acc_obj->GetStringAttribute(content::AccessibilityNodeData::ATTR_DESCRIPTION,

&description);

+ string16 help;

+ acc_obj->GetStringAttribute(content::AccessibilityNodeData::ATTR_HELP, &help);

const std::vector<string16>& ia2_attributes = acc_obj->ia2_attributes();

// Build the line.