content/test/data/accessibility/checkbox-name-calc.html - Issue 10823073: Improve accessible name calculation on Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/checkbox-name-calc.html

Issue 10823073: Improve accessible name calculation on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unintentionally modified file Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/test/data/accessibility/button-name-calc-expected-win.txt ('K') | « content/test/data/accessibility/button-name-calc-expected-win.txt ('k') | content/test/data/accessibility/checkbox-name-calc-expected-mac.txt » ('j') | content/test/data/accessibility/input-text-name-calc-expected-win.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 @WIN-ALLOW:description*

	3 -->

	4 <html>

	5 <body>

	6 <input id="c0" type="checkbox" title="Title">

	7 <input id="c1" type="checkbox" title="Title">

	8 <input id="c2" type="checkbox" title="Title" aria-label="AriaLabel">

	9 <input id="c3" type="checkbox" title="Title" aria-label="AriaLabel"

	10 aria-labelledby="lb3">

	11 <input id="c4" type="checkbox" title="Title" aria-label="AriaLabel"

	12 aria-labelledby="lb4" aria-describedby="db4">

	13 <input id="c5" type="checkbox" aria-describedby="db5">

	14
	aboxhall 2012/08/01 01:56:57 You might want to add a test for getting the name You might want to add a test for getting the name from contents, similar to the button role, since checkbox has name from: contents as well. dmazzoni 2012/08/01 03:22:41 I could be wrong but I think that's only for an AR Show quoted text On 2012/08/01 01:56:57, aboxhall wrote: > You might want to add a test for getting the name from contents, similar to the > button role, since checkbox has name from: contents as well. I could be wrong but I think that's only for an ARIA checkbox. I'm happy to do that but that should be a different test. I don't think an <input type="checkbox"> can have inner text. aboxhall 2012/08/06 01:55:49 Oh, oops, I misread type="checkbox" for role="chec Show quoted text On 2012/08/01 03:22:41, Dominic Mazzoni wrote: > On 2012/08/01 01:56:57, aboxhall wrote: > > You might want to add a test for getting the name from contents, similar to > the > > button role, since checkbox has name from: contents as well. > > I could be wrong but I think that's only for an ARIA checkbox. > > I'm happy to do that but that should be a different test. I don't think an > <input type="checkbox"> can have inner text. Oh, oops, I misread type="checkbox" for role="checkbox". Sorry!
	15 <p aria-label="@NO_DUMP">
	aboxhall 2012/08/06 01:55:49 Just for my understanding for writing tests in fut Just for my understanding for writing tests in future: I assume this means that the dumped accessibility tree should ignore this node and its children. Is this the only way to do this, or could it be done with a dummy attribute e.g. <p dump="@NO_DUMP">?
	16 <label for="c1">Label</label>

	17 <label for="c2">Label</label>

	18 <label for="c3">Label</label>

	19 <label for="c4">Label</label>

	20 <span id="lb3">LabelledBy</span>

	21 <span id="lb4">LabelledBy</span>

	22 <span id="db4">DescribedBy</span>

	23 <span id="db5">DescribedBy</span>

	24 </p>

	25 </body>

	26 </html>

OLD	NEW