content/test/data/accessibility/button-name-calc.html - Issue 10823073: Improve accessible name calculation on Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/button-name-calc.html

Issue 10823073: Improve accessible name calculation on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unintentionally modified file Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/accessibility/dump_accessibility_tree_helper_win.cc ('K') | « content/browser/accessibility/dump_accessibility_tree_helper_win.cc ('k') | content/test/data/accessibility/button-name-calc-expected-mac.txt » ('j') | content/test/data/accessibility/button-name-calc-expected-win.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 @WIN-ALLOW:description*

	3 -->

	4 <html>

	5 <body>

	6 <button id="c0">InnerText</button>

	7 <button id="c1" title="Title">InnerText</button>
	aboxhall 2012/08/01 01:56:57 Would it be worthwhile having a more complicated e Would it be worthwhile having a more complicated example of content, for example an image with an alt text, or an element with an aria-labelledby which refers to a hidden element? dmazzoni 2012/08/01 03:22:41 Yes! But maybe for the next test? This is complica Show quoted text On 2012/08/01 01:56:57, aboxhall wrote: > Would it be worthwhile having a more complicated example of content, for example > an image with an alt text, or an element with an aria-labelledby which refers to > a hidden element? Yes! But maybe for the next test? This is complicated enough and the only thing I wanted to cover in this test is the relative priorities of text alternatives, and what MSAA attributes they get assigned to. Let's do another set of tests on concatenating accessible titles inside inner text, etc. aboxhall 2012/08/06 01:55:49 Makes sense, and I've certainly caused enough dela Show quoted text On 2012/08/01 03:22:41, Dominic Mazzoni wrote: > On 2012/08/01 01:56:57, aboxhall wrote: > > Would it be worthwhile having a more complicated example of content, for > example > > an image with an alt text, or an element with an aria-labelledby which refers > to > > a hidden element? > > Yes! But maybe for the next test? This is complicated enough and the only thing > I wanted to cover in this test is the relative priorities of text alternatives, > and what MSAA attributes they get assigned to. > > Let's do another set of tests on concatenating accessible titles inside inner > text, etc. Makes sense, and I've certainly caused enough delay on this change set.
	8 <button id="c2" title="Title" aria-label="AriaLabel">InnerText</button>

	9 <button id="c3" title="Title" aria-label="AriaLabel"

	10 aria-labelledby="lb3">InnerText</button>

	11 <button id="c4" title="Title" aria-label="AriaLabel"

	12 aria-labelledby="lb4" aria-describedby="db4">InnerText</button>

	13 <button id="c5" aria-describedby="db5">InnerText</button>

	14

	15 <p aria-label="@NO_DUMP">

	16 <span id="lb3">LabelledBy</span>

	17 <span id="lb4">LabelledBy</span>

	18 <span id="db4">DescribedBy</span>

	19 <span id="db5">DescribedBy</span>

	20 </p>

	21 </body>

	22 </html>

OLD	NEW