Introducing the DaemonProcess class that will implements core of the daemon process functionality. …

Introducing the DaemonProcess class that will implements core of the daemon process functionality. It will manage the networking process running at lower privileges and maintains the list of virtual terminals.

BUG=134694
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149347

[alexeypa (please no reviews), 2012-07-27 21:40:05]

Please take a look.

[Sergey Ulanov, 2012-07-30 19:50:04]

LGTM when my nits are addressed.

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process.h
File remoting/host/daemon_process.h (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process.h...
remoting/host/daemon_process.h:50: virtual void DoShutdown();
OVERRIDE

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process_w...
File remoting/host/daemon_process_win.cc (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process_w...
remoting/host/daemon_process_win.cc:10: namespace {
nit: better to put this inside remoting namespace so that you don't have to
specify namespace for classes in the remoting namespace

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win.cc
File remoting/host/host_service_win.cc (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:114: void
HostService::OnShutdownableStopped(Shutdownable* /* launcher */) {
OnChildStopped?

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:201: #else
// !defined(REMOTING_MULTI_PROCESS)

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:219: #endif  //
defined(REMOTING_MULTI_PROCESS)
nit: // !defined(REMOTING_MULTI_PROCESS)

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win.h
File remoting/host/host_service_win.h (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.h:98: scoped_ptr<WtsSessionProcessLauncher>
child_;
This is used only to call Shutdown(), so maybe make it scoped_ptr<Shutdownable>
so that it's the same type in both cases?

http://codereview.chromium.org/10823062/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10823062/diff/1/remoting/remoting.gyp#newcode7
remoting/remoting.gyp:7: 'remoting_multi_process%': 0,
Nit: Kerry recently added remoting_audio variable in this file. Please group
them together after merging his change

[alexeypa (please no reviews), 2012-07-30 21:50:03]

Please take another look.

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process.h
File remoting/host/daemon_process.h (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process.h...
remoting/host/daemon_process.h:50: virtual void DoShutdown();
On 2012/07/30 19:50:04, sergeyu wrote:
> OVERRIDE

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process_w...
File remoting/host/daemon_process_win.cc (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/daemon_process_w...
remoting/host/daemon_process_win.cc:10: namespace {
On 2012/07/30 19:50:04, sergeyu wrote:
> nit: better to put this inside remoting namespace so that you don't have to
> specify namespace for classes in the remoting namespace 

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win.cc
File remoting/host/host_service_win.cc (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:114: void
HostService::OnShutdownableStopped(Shutdownable* /* launcher */) {
On 2012/07/30 19:50:04, sergeyu wrote:
> OnChildStopped?

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:201: #else
On 2012/07/30 19:50:04, sergeyu wrote:
> // !defined(REMOTING_MULTI_PROCESS)

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.cc:219: #endif  //
defined(REMOTING_MULTI_PROCESS)
On 2012/07/30 19:50:04, sergeyu wrote:
> nit: // !defined(REMOTING_MULTI_PROCESS)

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win.h
File remoting/host/host_service_win.h (right):

http://codereview.chromium.org/10823062/diff/1/remoting/host/host_service_win...
remoting/host/host_service_win.h:98: scoped_ptr<WtsSessionProcessLauncher>
child_;
On 2012/07/30 19:50:04, sergeyu wrote:
> This is used only to call Shutdown(), so maybe make it
scoped_ptr<Shutdownable>
> so that it's the same type in both cases?

Done.

http://codereview.chromium.org/10823062/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10823062/diff/1/remoting/remoting.gyp#newcode7
remoting/remoting.gyp:7: 'remoting_multi_process%': 0,
On 2012/07/30 19:50:04, sergeyu wrote:
> Nit: Kerry recently added remoting_audio variable in this file. Please group
> them together after merging his change

Will do.

[alexeypa (please no reviews), 2012-07-30 21:50:27]

On 2012/07/30 21:50:03, alexeypa wrote:
> Please take another look.

I meant FYI. :-)

[commit-bot: I haz the power, 2012-07-31 22:54:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10823062/1009

[commit-bot: I haz the power, 2012-08-01 01:28:59]

Change committed as 149347