chrome/browser/resources/chromeos/drive_internals.html - Issue 10823039: gdata: Add GCache Contents section to chrome:drive-internals

Side by Side Diff: chrome/browser/resources/chromeos/drive_internals.html

Issue 10823039: gdata: Add GCache Contents section to chrome:drive-internals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add css Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/resources/chromeos/drive_internals.css ('k') | chrome/browser/resources/chromeos/drive_internals.js » ('j') | chrome/browser/resources/chromeos/drive_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>drive-internals</title>	4 <title>drive-internals</title>

5 <meta charset="utf-8">	5 <meta charset="utf-8">

	6 <link rel="stylesheet" href="drive_internals.css">

6 <script src="chrome://resources/js/util.js"></script>	7 <script src="chrome://resources/js/util.js"></script>

7 <script src="chrome://drive-internals/drive_internals.js"></script>	8 <script src="chrome://drive-internals/drive_internals.js"></script>

8 </head>	9 </head>

9 <body>	10 <body>

10 <h1>Drive Internals</h1>	11 <h1>Drive Internals</h1>

11 <h2>Authentication Status</h2>	12 <h2>Authentication Status</h2>

12 <table>	13 <table>
	James Hawkins 2012/07/26 17:50:02 I'm not going to ask you to do this in this CL, th I'm not going to ask you to do this in this CL, this should not be using table (it's not tabular data). Please add a TODO to remove the use of table. satorux1 2012/07/26 19:18:14 Sounds reasonable. I'd rather fix now. :) For now Show quoted text On 2012/07/26 17:50:02, James Hawkins wrote: > I'm not going to ask you to do this in this CL, this should not be using table > (it's not tabular data). Please add a TODO to remove the use of table. Sounds reasonable. I'd rather fix now. :) For now, I changed it to simple <ul>+<li>. Originally, I chose to use table to make the key value pairs vertically aligned. What would be a recommended way to do it without a table? James Hawkins 2012/07/26 19:30:41 Check out table.css in shared/. Show quoted text On 2012/07/26 19:18:14, satorux1 wrote: > On 2012/07/26 17:50:02, James Hawkins wrote: > > I'm not going to ask you to do this in this CL, this should not be using table > > (it's not tabular data). Please add a TODO to remove the use of table. > > Sounds reasonable. I'd rather fix now. :) > > For now, I changed it to simple <ul>+<li>. Originally, I chose to use table to > make the key value pairs vertically aligned. What would be a recommended way to > do it without a table? Check out table.css in shared/. satorux1 2012/07/26 20:29:23 Thanks. I'll take a look. Show quoted text On 2012/07/26 19:30:41, James Hawkins wrote: > On 2012/07/26 19:18:14, satorux1 wrote: > > On 2012/07/26 17:50:02, James Hawkins wrote: > > > I'm not going to ask you to do this in this CL, this should not be using > table > > > (it's not tabular data). Please add a TODO to remove the use of table. > > > > Sounds reasonable. I'd rather fix now. :) > > > > For now, I changed it to simple <ul>+<li>. Originally, I chose to use table to > > make the key value pairs vertically aligned. What would be a recommended way > to > > do it without a table? > > Check out table.css in shared/. Thanks. I'll take a look.
13 <tbody>	14 <tbody>

14 <tr><td>Has refresh token</td><td id='has-refresh-token'></td></tr>	15 <tr><td>Has refresh token</td><td id='has-refresh-token'></td></tr>
	James Hawkins 2012/07/26 17:50:02 nit: Drop <td> and co to next line, indented. nit: Drop <td> and co to next line, indented. satorux1 2012/07/26 19:18:14 the table is gone now. Show quoted text On 2012/07/26 17:50:02, James Hawkins wrote: > nit: Drop <td> and co to next line, indented. the table is gone now.
15 <tr><td>Has access token</td><td id='has-access-token'></td></tr>	16 <tr><td>Has access token</td><td id='has-access-token'></td></tr>

16 </tbody>	17 </tbody>

17 </table>	18 </table>

	19 <h2>GCache Contents</h2>

	20 <table>

	21 <tbody id='gcache-contents'>
	James Hawkins 2012/07/26 17:50:02 nit: Move the </tbody> to this line since it's fit nit: Move the </tbody> to this line since it's fits w/in 80 cols. satorux1 2012/07/26 19:18:14 Done. Show quoted text On 2012/07/26 17:50:02, James Hawkins wrote: > nit: Move the </tbody> to this line since it's fits w/in 80 cols. Done.
	22 </tbody>

	23 </table>

18 </body>	24 </body>

19 </html>	25 </html>

OLD	NEW