Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10823018: Add a developer hint log message for when RLIMIT_AS is the culprint in startup failure. (Closed)

Created:
8 years, 5 months ago by bsy
Modified:
8 years, 5 months ago
Reviewers:
Brad Chen
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add a developer hint log message for when RLIMIT_AS is the culprint in startup failure. Tested w/ pending plugin-side CL http://codereview.chromium.org/10823019/ via: bash -c 'ulimit -v 1000000; /mm/bsy/chromium/chromium64.git0/src/out/Release/chrome --user-data-dir=/tmp/udd' and trying to run Duke Nukem in NaClBox and seeing the log messages show up in the JavaScript console. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2776 TEST= manual, requires a pending plugin CL. Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9256

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M src/trusted/service_runtime/arch/x86_64/sel_addrspace_posix_x86_64.c View 3 chunks +50 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
bsy
8 years, 5 months ago (2012-07-25 20:06:45 UTC) #1
Brad Chen
LGTM https://chromiumcodereview.appspot.com/10823018/diff/1/src/trusted/service_runtime/arch/x86_64/sel_addrspace_posix_x86_64.c File src/trusted/service_runtime/arch/x86_64/sel_addrspace_posix_x86_64.c (right): https://chromiumcodereview.appspot.com/10823018/diff/1/src/trusted/service_runtime/arch/x86_64/sel_addrspace_posix_x86_64.c#newcode155 src/trusted/service_runtime/arch/x86_64/sel_addrspace_posix_x86_64.c:155: "Please run \"ulimit -v unlimited\" (bash)" If we ...
8 years, 5 months ago (2012-07-25 20:28:09 UTC) #2
Brad Chen
Thinking a bit more; will this work inside the SUID sandbox?
8 years, 5 months ago (2012-07-25 20:29:03 UTC) #3
bsy
yes. i run chrome w/ CHROME_DEVEL_SANDBOX set to /opt/google/chrome/chrome-sandbox and it's working fine.
8 years, 5 months ago (2012-07-25 20:39:20 UTC) #4
bsy
8 years, 5 months ago (2012-07-25 22:09:02 UTC) #5
thx.  Committed revision 9256.

Powered by Google App Engine
This is Rietveld 408576698