Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10821126: adding redirect from codesite to chrome domain (bug 138776) (Closed)

Created:
8 years, 4 months ago by ernestd1
Modified:
8 years, 4 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

adding redirect from codesite to chrome domain (bug 138776) BUG=138776 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149811

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/common/extensions/docs/server/main.py View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ernestd1
8 years, 4 months ago (2012-08-01 08:53:51 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/10821126/diff/1/chrome/common/extensions/docs/server/main.py File chrome/common/extensions/docs/server/main.py (right): http://codereview.chromium.org/10821126/diff/1/chrome/common/extensions/docs/server/main.py#newcode189 chrome/common/extensions/docs/server/main.py:189: self.path.insert(0, '') This is a little magical. Instead ...
8 years, 4 months ago (2012-08-01 09:58:54 UTC) #2
ernestd1
On 2012/08/01 09:58:54, Aaron Boodman wrote: > lgtm > > http://codereview.chromium.org/10821126/diff/1/chrome/common/extensions/docs/server/main.py > File chrome/common/extensions/docs/server/main.py (right): ...
8 years, 4 months ago (2012-08-01 12:42:59 UTC) #3
Aaron Boodman
8 years, 4 months ago (2012-08-01 21:45:03 UTC) #4
still lgtm

Powered by Google App Engine
This is Rietveld 408576698