sync: Attempt to recover from directory corruption

chrome/browser/sync/profile_sync_service.cc

Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index af0299b953503f2c7c69d2580da708f882a4aaea..c6ec23a1b5b0869e33c85cdcf1b3614cd144f19b 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -663,6 +663,13 @@ void ProfileSyncService::OnBackendInitialized(
     // Keep the directory around for now so that on restart we will retry
     // again and potentially succeed in presence of transient file IO failures
     // or permissions issues, etc.
+    //
+    // TODO(rlarocque): Consider making this UnrecoverableError less special.
+    // This exception made sense at the time it was implemented, but our new
+    // directory corruption recovery mechanism makes it obsolete.  By the time
+    // we get here, we will have already tried and failed to delete the
+    // directory.  Whether or not we try to delete it again after the error is

[tim (not reviewing), 2012/08/02 00:31:18]

Ah, maybe reword these last sentences to be explicit that it's fine to delete it
here, the 'false' bool is conveniently totally ambiguous and I got confused.
"There may not be much point to keeping the directory around, since by the time
we get here, we have already tried and failed to delete the directory."

+    // thrown likely won't make a difference.
     OnInternalUnrecoverableError(FROM_HERE,
                                  "BackendInitialize failure",
                                  false,