sync: Attempt to recover from directory corruption

chrome/browser/sync/profile_sync_service.cc

Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index af0299b953503f2c7c69d2580da708f882a4aaea..ef177fea8df8fb760dddc6bf223201f40251701a 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -385,6 +385,13 @@ void ProfileSyncService::OnSyncConfigureRetry() {
   // unrecoverable error, even if the platform has auto start disabled.
   // Note: In those scenarios the UI does not wait for the configuration
   // to finish.
+  //
+  // TODO(rlarocque): Consider making this UnrecoverableError less special.
+  // This exception made sense at the time it was implemented, but our new
+  // directory corruption recovery mechanism makes it obsolete.  By the time we
+  // get here, we will have already tried and failed to delete the directory.
+  // Whether or not we try to delete it again after the error is thrown likely
+  // won't make a difference.

[tim (not reviewing), 2012/08/01 21:31:59]

Hmm... I don't follow.  I thought this was called when a sync cycle failed to
download nigori, but the scheduler has set up another pending job.  How or where
will we have tried to delete the directory ?

[rlarocque, 2012/08/01 21:53:50]

Woops, that was a dumb mistake.  This comment belongs next to the
UnrecoverableError on line 673.

   if (!auto_start_enabled_ && !backend_initialized_) {
     OnInternalUnrecoverableError(FROM_HERE,
                                  "Configure failed to download.",