Send user gesture to extensions for page and browser action clicks.

Send user gesture to extensions for page and browser action clicks.

R=aa@chromium.org
BUG=128964
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149458

[Aaron Boodman, 2012-08-01 11:38:39]

.redirect("mpcomplete")

[Matt Perry, 2012-08-01 11:57:17]

LGTM assuming my concern below is unjustified.

http://codereview.chromium.org/10821120/diff/1/chrome/browser/extensions/brow...
File chrome/browser/extensions/browser_event_router.cc (right):

http://codereview.chromium.org/10821120/diff/1/chrome/browser/extensions/brow...
chrome/browser/extensions/browser_event_router.cc:279:
EventRouter::USER_GESTURE_ENABLED : EventRouter::USER_GESTURE_NOT_ENABLED;
Hmm... yes, technically a user gesture caused this method to be invoked. But
should that user gesture propagate to the extension? The user was interacting
with chrome's UI, not the extension's.

Maybe I'm just misunderstanding how user_gesture should be propagated.

[Greg Billock, 2012-08-01 16:43:43]

http://codereview.chromium.org/10821120/diff/1/chrome/browser/extensions/brow...
File chrome/browser/extensions/browser_event_router.cc (right):

http://codereview.chromium.org/10821120/diff/1/chrome/browser/extensions/brow...
chrome/browser/extensions/browser_event_router.cc:279:
EventRouter::USER_GESTURE_ENABLED : EventRouter::USER_GESTURE_NOT_ENABLED;
I think this is an accurate propagation. That is, the user gesture indicator
tells the JS code "you are running as a direct result of a user interaction". So
if extension JS code is a handler for a browser UI element (context menu entry,
page/browser action click), it should carry the indicator.

On 2012/08/01 11:57:17, Matt Perry wrote:
> Hmm... yes, technically a user gesture caused this method to be invoked. But
> should that user gesture propagate to the extension? The user was interacting
> with chrome's UI, not the extension's.
> 
> Maybe I'm just misunderstanding how user_gesture should be propagated.

[commit-bot: I haz the power, 2012-08-01 18:08:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10821120/1

[commit-bot: I haz the power, 2012-08-01 19:15:37]

Change committed as 149458