third_party/apple_sample_code/README.chromium - Issue 10821103: Make 'License' field in third-party metadata required

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/apple_sample_code/README.chromium

Issue 10821103: Make 'License' field in third-party metadata required (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 Name: Apple sample code	1 Name: Apple sample code

2 URL: http://developer.apple.com/	2 URL: http://developer.apple.com/

3 Version: unknown	3 Version: unknown

4 Security Critical: Yes	4 Security Critical: Yes

	5 License: Custom license

5	6

6 Local changes:	7 Local changes:

7 * ImageAndTextCell.h: Changed 'image' property to 'retain' mode to fix a crash.	8 * ImageAndTextCell.h: Changed 'image' property to 'retain' mode to fix a crash.

8 * ImageAndTextCell.m: Moved '@synthesize' to to the top of '@implementation' as	9 * ImageAndTextCell.m: Moved '@synthesize' to to the top of '@implementation' as

9 suggested by a clang warning.	10 suggested by a clang warning.

10 * ImageAndTextCell.m: Switched from -[NSImage compositeToPoint:operation:] to	11 * ImageAndTextCell.m: Switched from -[NSImage compositeToPoint:operation:] to

11 -[NSImage drawInRect:fromRect:operation:fraction:respectFl ipped:hints:]	12 -[NSImage drawInRect:fromRect:operation:fraction:respectFl ipped:hints:]

12 as the former is deprecated and doesn't work properly in	13 as the former is deprecated and doesn't work properly in

13 HiDPI.	14 HiDPI.

OLD	NEW