sync/internal_api/js_sync_manager_observer.cc - Issue 10821091: Fix leak in JsSyncManagerObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/js_sync_manager_observer.cc

Issue 10821091: Fix leak in JsSyncManagerObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/js_sync_manager_observer.cc

diff --git a/sync/internal_api/js_sync_manager_observer.cc b/sync/internal_api/js_sync_manager_observer.cc

index 078e1e9a51d32d72dc496ba44cea6f36a4f4b4b0..f0171078ff2836ea0552433f9c9e1a3543fed63d 100644

--- a/sync/internal_api/js_sync_manager_observer.cc

+++ b/sync/internal_api/js_sync_manager_observer.cc

@@ -131,10 +131,12 @@ void JsSyncManagerObserver::OnInitializationComplete(

// Ignore the |js_backend| argument; it's not really convertible to

// JSON anyway.

- DictionaryValue* details = new DictionaryValue();

- details->Set("restoredTypes", ModelTypeSetToValue(restored_types));

+ DictionaryValue details;

+ details.Set("restoredTypes", ModelTypeSetToValue(restored_types));

- HandleJsEvent(FROM_HERE, "onInitializationComplete", JsEventDetails(details));

+ HandleJsEvent(FROM_HERE,

+ "onInitializationComplete",

+ JsEventDetails(&details));

}

void JsSyncManagerObserver::OnStopSyncingPermanently() {