Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 10821077: Add gallery permissions to Media Galleries Preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extension_prefs_unittest.h" 5 #include "extension_prefs_unittest.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/scoped_temp_dir.h" 9 #include "base/scoped_temp_dir.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 private: 98 private:
99 Time extension_time_; 99 Time extension_time_;
100 Time blacklist_time_; 100 Time blacklist_time_;
101 std::string extension_id_; 101 std::string extension_id_;
102 }; 102 };
103 TEST_F(ExtensionPrefsLastPingDay, LastPingDay) {} 103 TEST_F(ExtensionPrefsLastPingDay, LastPingDay) {}
104 104
105 namespace { 105 namespace {
106 106
107 void AddGalleryPermission(MediaGalleryPrefId gallery, bool has_access, 107 void AddGalleryPermission(chrome::MediaGalleryPrefId gallery, bool has_access,
108 std::vector<MediaGalleryPermission>* vector) { 108 std::vector<chrome::MediaGalleryPermission>* vector) {
109 MediaGalleryPermission permission; 109 chrome::MediaGalleryPermission permission;
110 permission.pref_id = gallery; 110 permission.pref_id = gallery;
111 permission.has_permission = has_access; 111 permission.has_permission = has_access;
112 vector->push_back(permission); 112 vector->push_back(permission);
113 } 113 }
114 114
115 } // namspace 115 } // namspace
116 116
117 // Test the MediaGalleries permissions functions. 117 // Test the MediaGalleries permissions functions.
118 class MediaGalleriesPermissions : public ExtensionPrefsTest { 118 class MediaGalleriesPermissions : public ExtensionPrefsTest {
119 public: 119 public:
(...skipping 26 matching lines...) Expand all
146 Verify(); 146 Verify();
147 147
148 prefs()->SetMediaGalleryPermission(extension3_id_, 3, true); 148 prefs()->SetMediaGalleryPermission(extension3_id_, 3, true);
149 AddGalleryPermission(3, true, &extension3_expectation_); 149 AddGalleryPermission(3, true, &extension3_expectation_);
150 Verify(); 150 Verify();
151 151
152 prefs()->RemoveMediaGalleryPermissions(3); 152 prefs()->RemoveMediaGalleryPermissions(3);
153 extension2_expectation_.erase(extension2_expectation_.begin() + 1); 153 extension2_expectation_.erase(extension2_expectation_.begin() + 1);
154 extension3_expectation_.erase(extension3_expectation_.begin()); 154 extension3_expectation_.erase(extension3_expectation_.begin());
155 Verify(); 155 Verify();
156
157 prefs()->UnsetMediaGalleryPermission(extension1_id_, 1);
158 extension1_expectation_.erase(extension1_expectation_.begin());
159 Verify();
156 } 160 }
157 161
158 virtual void Verify() { 162 virtual void Verify() {
159 struct TestData { 163 struct TestData {
160 std::string* id; 164 std::string* id;
161 std::vector<MediaGalleryPermission>* expectation; 165 std::vector<chrome::MediaGalleryPermission>* expectation;
162 }; 166 };
163 167
164 const TestData test_data[] = {{&extension1_id_, &extension1_expectation_}, 168 const TestData test_data[] = {{&extension1_id_, &extension1_expectation_},
165 {&extension2_id_, &extension2_expectation_}, 169 {&extension2_id_, &extension2_expectation_},
166 {&extension3_id_, &extension3_expectation_}, 170 {&extension3_id_, &extension3_expectation_},
167 {&extension4_id_, &extension4_expectation_}}; 171 {&extension4_id_, &extension4_expectation_}};
168 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); i++) { 172 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); i++) {
169 std::vector<MediaGalleryPermission> actual = 173 std::vector<chrome::MediaGalleryPermission> actual =
170 prefs()->GetMediaGalleryPermissions(*test_data[i].id); 174 prefs()->GetMediaGalleryPermissions(*test_data[i].id);
171 EXPECT_EQ(test_data[i].expectation->size(), actual.size()); 175 EXPECT_EQ(test_data[i].expectation->size(), actual.size());
172 for (size_t permission_entry = 0; 176 for (size_t permission_entry = 0;
173 permission_entry < test_data[i].expectation->size() && 177 permission_entry < test_data[i].expectation->size() &&
174 permission_entry < actual.size(); 178 permission_entry < actual.size();
175 permission_entry++) { 179 permission_entry++) {
176 EXPECT_EQ(test_data[i].expectation->at(permission_entry).pref_id, 180 EXPECT_EQ(test_data[i].expectation->at(permission_entry).pref_id,
177 actual[permission_entry].pref_id); 181 actual[permission_entry].pref_id);
178 EXPECT_EQ(test_data[i].expectation->at(permission_entry).has_permission, 182 EXPECT_EQ(test_data[i].expectation->at(permission_entry).has_permission,
179 actual[permission_entry].has_permission); 183 actual[permission_entry].has_permission);
180 } 184 }
181 } 185 }
182 } 186 }
183 187
184 private: 188 private:
185 std::string extension1_id_; 189 std::string extension1_id_;
186 std::string extension2_id_; 190 std::string extension2_id_;
187 std::string extension3_id_; 191 std::string extension3_id_;
188 std::string extension4_id_; 192 std::string extension4_id_;
189 193
190 std::vector<MediaGalleryPermission> extension1_expectation_; 194 std::vector<chrome::MediaGalleryPermission> extension1_expectation_;
191 std::vector<MediaGalleryPermission> extension2_expectation_; 195 std::vector<chrome::MediaGalleryPermission> extension2_expectation_;
192 std::vector<MediaGalleryPermission> extension3_expectation_; 196 std::vector<chrome::MediaGalleryPermission> extension3_expectation_;
193 std::vector<MediaGalleryPermission> extension4_expectation_; 197 std::vector<chrome::MediaGalleryPermission> extension4_expectation_;
194 }; 198 };
195 TEST_F(MediaGalleriesPermissions, MediaGalleries) {} 199 TEST_F(MediaGalleriesPermissions, MediaGalleries) {}
196 200
197 // Tests the GetToolbarOrder/SetToolbarOrder functions. 201 // Tests the GetToolbarOrder/SetToolbarOrder functions.
198 class ExtensionPrefsToolbarOrder : public ExtensionPrefsTest { 202 class ExtensionPrefsToolbarOrder : public ExtensionPrefsTest {
199 public: 203 public:
200 virtual void Initialize() { 204 virtual void Initialize() {
201 list_.push_back(prefs_.AddExtensionAndReturnId("1")); 205 list_.push_back(prefs_.AddExtensionAndReturnId("1"));
202 list_.push_back(prefs_.AddExtensionAndReturnId("2")); 206 list_.push_back(prefs_.AddExtensionAndReturnId("2"));
203 list_.push_back(prefs_.AddExtensionAndReturnId("3")); 207 list_.push_back(prefs_.AddExtensionAndReturnId("3"));
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 EXPECT_EQ(string16(), error16); 1257 EXPECT_EQ(string16(), error16);
1254 EXPECT_TRUE(prefs()->UserMayModifySettings(extension_.get(), &error16)); 1258 EXPECT_TRUE(prefs()->UserMayModifySettings(extension_.get(), &error16));
1255 EXPECT_EQ(string16(), error16); 1259 EXPECT_EQ(string16(), error16);
1256 EXPECT_FALSE(prefs()->MustRemainEnabled(extension_.get(), &error16)); 1260 EXPECT_FALSE(prefs()->MustRemainEnabled(extension_.get(), &error16));
1257 EXPECT_EQ(string16(), error16); 1261 EXPECT_EQ(string16(), error16);
1258 } 1262 }
1259 }; 1263 };
1260 TEST_F(ExtensionPrefsNotRequiredExtension, NotRequiredExtension) {} 1264 TEST_F(ExtensionPrefsNotRequiredExtension, NotRequiredExtension) {}
1261 1265
1262 } // namespace extensions 1266 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/media_gallery/media_file_system_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698