Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4181)

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 10821035: wip Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/back_forward_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model.cc b/chrome/browser/ui/toolbar/back_forward_menu_model.cc
index a5982223cbb5eda1b350a35681387a25ca1249e0..2961ceb038c116b8921c7366f4f55229867de7b2 100644
--- a/chrome/browser/ui/toolbar/back_forward_menu_model.cc
+++ b/chrome/browser/ui/toolbar/back_forward_menu_model.cc
@@ -278,8 +278,9 @@ void BackForwardMenuModel::OnFavIconDataAvailable(
// Now that we have a valid NavigationEntry, decode the favicon and assign
// it to the NavigationEntry.
SkBitmap fav_icon;
- if (gfx::PNGCodec::Decode(favicon.bitmap_data->front(),
- favicon.bitmap_data->size(),
+ if (favicon.variants.size() > 0 && // XXX
+ gfx::PNGCodec::Decode(favicon.variants[0].bitmap_data->front(),
+ favicon.variants[0].bitmap_data->size(),
&fav_icon)) {
entry->GetFavicon().valid = true;
entry->GetFavicon().url = favicon.icon_url;

Powered by Google App Engine
This is Rietveld 408576698