Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10821028: Basic Debian packaging for Linux Me2Me host (Closed)

Created:
8 years, 5 months ago by Lambros
Modified:
8 years, 5 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Basic Debian packaging for Linux Me2Me host This facilitates building a Debian package, currently for Ubuntu 10.04. This is based on work by benley@ and jamiewalch@ (http://codereview.chromium.org/10800099/) TODO: * Allow building packages for other versions of Ubuntu (maybe detect the current build platform and use that) * Integrate better with gyp, instead of hard-coding out/Release and manually supplying version_full to the script. * Add man-page for me2me_virtual_host * Use separate staging area for the debian/ build directory, instead of polluting the source tree. BUG=131245 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148701

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments #

Total comments: 6

Patch Set 3 : Add copyright notices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -2 lines) Patch
A remoting/host/installer/linux/Makefile View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A remoting/host/installer/linux/build-deb.sh View 1 1 chunk +21 lines, -0 lines 0 comments Download
A remoting/host/installer/linux/debian/compat View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/host/installer/linux/debian/control View 1 1 chunk +19 lines, -0 lines 0 comments Download
A remoting/host/installer/linux/debian/copyright View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/host/installer/linux/debian/rules View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/tools/keygen.py View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/tools/me2me_virtual_host.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lambros
8 years, 5 months ago (2012-07-25 21:53:09 UTC) #1
Jamie
http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/build-deb.sh#newcode8 remoting/host/installer/linux/build-deb.sh:8: version_full="${version_full:-1.2.3.4}" Probably better to fail if version_full isn't set. ...
8 years, 5 months ago (2012-07-25 23:40:40 UTC) #2
Lambros
http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/build-deb.sh#newcode8 remoting/host/installer/linux/build-deb.sh:8: version_full="${version_full:-1.2.3.4}" On 2012/07/25 23:40:40, Jamie wrote: > Probably better ...
8 years, 5 months ago (2012-07-26 21:19:04 UTC) #3
Jamie
lgtm with a few nits. http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/debian/compat File remoting/host/installer/linux/debian/compat (right): http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/debian/compat#newcode1 remoting/host/installer/linux/debian/compat:1: 7 On 2012/07/26 21:19:04, ...
8 years, 5 months ago (2012-07-26 21:50:31 UTC) #4
Lambros
http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/debian/compat File remoting/host/installer/linux/debian/compat (right): http://codereview.chromium.org/10821028/diff/1/remoting/host/installer/linux/debian/compat#newcode1 remoting/host/installer/linux/debian/compat:1: 7 On 2012/07/26 21:50:31, Jamie wrote: > On 2012/07/26 ...
8 years, 5 months ago (2012-07-26 23:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10821028/9001
8 years, 5 months ago (2012-07-26 23:42:59 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-27 02:22:33 UTC) #7
Change committed as 148701

Powered by Google App Engine
This is Rietveld 408576698