Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1082008: Fix the out-of-bounds array read in the ftp response... (Closed)

Created:
10 years, 9 months ago by inferno
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix the out-of-bounds array read in the ftp response. BUG=38845 TEST=Pass a ftp server response having two double quotes with no character in between and verify no browser crash happens. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/ftp/ftp_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
inferno
Hey Chris, Justin, Please review this easy one-liner. i think we should merge this to ...
10 years, 9 months ago (2010-03-21 22:04:33 UTC) #1
Chris Evans
LGTM Yep, please merge this 1-liner to the 4.1 branch once submitted to trunk. Also, ...
10 years, 9 months ago (2010-03-22 00:13:28 UTC) #2
Paweł Hajdan Jr.
10 years, 9 months ago (2010-03-22 06:45:46 UTC) #3
Drive-by.

Could you please add a test for that in ftp_network_transaction_unittest.cc?

Powered by Google App Engine
This is Rietveld 408576698