Fix issue 977

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 2380 matching lines @@
                "const constructor '%s' may not have function body",
                method->name->ToCString());
     } else if (method->IsFactory() && method->has_const) {
       ErrorMsg(method->name_pos,
                "const factory '%s' may not have function body",
                method->name->ToCString());
     } else if (members->is_interface()) {
       ErrorMsg(method->name_pos,
                "function body not allowed in interface declaration");
     }
+    if (method->redirect_name != NULL) {
+      ErrorMsg(method->name_pos,
+               "Constructor with redirection may not have function body");

[cshapiro, 2012/07/27 23:17:12]

This might read better with the indefinite article.  Consider this alternative

  "Constructor with redirection may not have a function body"

+    }
     if (CurrentToken() == Token::kLBRACE) {
       SkipBlock();
     } else {
       ConsumeToken();
       SkipExpr();
       ExpectSemicolon();
     }
     method_end_pos = TokenPos();
   } else if (IsLiteral("native")) {
     if (method->has_abstract) {
       ErrorMsg(method->name_pos,
                "abstract method '%s' may not have function body",
                method->name->ToCString());
     } else if (members->is_interface()) {
       ErrorMsg(method->name_pos,
                "function body not allowed in interface declaration");
     } else if (method->IsConstructor() && method->has_const) {
       ErrorMsg(method->name_pos,
                "const constructor '%s' may not have function body",
                method->name->ToCString());
     }
+    if (method->redirect_name != NULL) {
+      ErrorMsg(method->name_pos,
+               "Constructor with redirection may not have function body");

[cshapiro, 2012/07/27 23:17:12]

ditto

+    }
     ParseNativeDeclaration();
   } else if (CurrentToken() == Token::kSEMICOLON) {
     if (members->is_interface() ||
         method->has_abstract ||
         (method->redirect_name != NULL) ||
         method->IsConstructor()) {
       ConsumeToken();
     } else {
       ErrorMsg(method->name_pos,
                "function body expected for method '%s'",
@@ skipping 6299 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart