src/arm/builtins-arm.cc - Issue 10818026: Relax requirement from VFP3 to VFP2 where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/builtins-arm.cc

Issue 10818026: Relax requirement from VFP3 to VFP2 where possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/builtins-arm.cc

diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc

index 12a914b280752023a4b40fe247fd9cc56fc2f156..40949ff35401c2898d14ea23ac00b0d37d1b0685 100644

--- a/src/arm/builtins-arm.cc

+++ b/src/arm/builtins-arm.cc

@@ -1283,10 +1283,7 @@ void Builtins::Generate_NotifyOSR(MacroAssembler* masm) {

void Builtins::Generate_OnStackReplacement(MacroAssembler* masm) {

CpuFeatures::TryForceFeatureScope scope(VFP3);

- if (!CpuFeatures::IsSupported(VFP3)) {

- __ Abort("Unreachable code: Cannot optimize without VFP3 support.");

- return;

- }

+ ASSERT(CPU::SupportsCrankshaft());

// Lookup the function in the JavaScript frame and push it as an

// argument to the on-stack replacement function.