Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/platform-linux.cc

Issue 10818026: Relax requirement from VFP3 to VFP2 where possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 125
126 126
127 bool OS::ArmCpuHasFeature(CpuFeature feature) { 127 bool OS::ArmCpuHasFeature(CpuFeature feature) {
128 const char* search_string = NULL; 128 const char* search_string = NULL;
129 // Simple detection of VFP at runtime for Linux. 129 // Simple detection of VFP at runtime for Linux.
130 // It is based on /proc/cpuinfo, which reveals hardware configuration 130 // It is based on /proc/cpuinfo, which reveals hardware configuration
131 // to user-space applications. According to ARM (mid 2009), no similar 131 // to user-space applications. According to ARM (mid 2009), no similar
132 // facility is universally available on the ARM architectures, 132 // facility is universally available on the ARM architectures,
133 // so it's up to individual OSes to provide such. 133 // so it's up to individual OSes to provide such.
134 switch (feature) { 134 switch (feature) {
135 case VFP2:
136 search_string = "vfp";
Rodolph Perfetta 2012/07/25 10:59:54 this will match the vfpv3 string since when they d
Yang 2012/07/25 12:09:32 since VFP3 implies VFP2, wouldn't this be fine? I'
137 break;
135 case VFP3: 138 case VFP3:
136 search_string = "vfpv3"; 139 search_string = "vfpv3";
137 break; 140 break;
138 case ARMv7: 141 case ARMv7:
139 search_string = "ARMv7"; 142 search_string = "ARMv7";
140 break; 143 break;
141 default: 144 default:
142 UNREACHABLE(); 145 UNREACHABLE();
143 } 146 }
144 147
(...skipping 1136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 1284
1282 1285
1283 void Sampler::Stop() { 1286 void Sampler::Stop() {
1284 ASSERT(IsActive()); 1287 ASSERT(IsActive());
1285 SignalSender::RemoveActiveSampler(this); 1288 SignalSender::RemoveActiveSampler(this);
1286 SetActive(false); 1289 SetActive(false);
1287 } 1290 }
1288 1291
1289 1292
1290 } } // namespace v8::internal 1293 } } // namespace v8::internal
OLDNEW
« src/arm/stub-cache-arm.cc ('K') | « src/flag-definitions.h ('k') | src/v8globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698