base/sys_string_conversions_mac_unittest.mm - Issue 10818016: [OSX] Remove wide->NSString conversion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/sys_string_conversions_mac_unittest.mm

Issue 10818016: [OSX] Remove wide->NSString conversion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing more widestring support Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Foundation/Foundation.h>	5 #import <Foundation/Foundation.h>

6	6

7 #include "base/string16.h"	7 #include "base/string16.h"

8 #include "base/sys_string_conversions.h"	8 #include "base/sys_string_conversions.h"

9 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

10	10

11 TEST(SysStrings, ConversionsFromNSString) {	11 TEST(SysStrings, ConversionsFromNSString) {

12 EXPECT_STREQ("Hello, world!",	12 EXPECT_STREQ("Hello, world!",

13 base::SysNSStringToUTF8(@"Hello, world!").c_str());	13 base::SysNSStringToUTF8(@"Hello, world!").c_str());

14	14

15 // Conversions should be able to handle a NULL value without crashing.	15 // Conversions should be able to handle a NULL value without crashing.

16 EXPECT_STREQ("", base::SysNSStringToUTF8(nil).c_str());	16 EXPECT_STREQ("", base::SysNSStringToUTF8(nil).c_str());

17 EXPECT_EQ(string16(), base::SysNSStringToUTF16(nil));	17 EXPECT_EQ(string16(), base::SysNSStringToUTF16(nil));

18 EXPECT_STREQ(L"", base::SysNSStringToWide(nil).c_str());

19 }	18 }

OLD	NEW