Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10818016: [OSX] Remove wide->NSString conversion (Closed)

Created:
8 years, 5 months ago by groby-ooo-7-16
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

[OSX] Remove wide->NSString conversion Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it. TBR=rsesek@chromium.org R=mark@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150002

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing more widestring support #

Total comments: 1

Patch Set 3 : Removed more widestring code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M base/sys_string_conversions.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M base/sys_string_conversions_mac.mm View 1 2 4 chunks +0 lines, -20 lines 0 comments Download
M base/sys_string_conversions_mac_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
8 years, 5 months ago (2012-07-24 16:31:23 UTC) #1
Mark Mentovai
http://codereview.chromium.org/10818016/diff/1/base/sys_string_conversions.h File base/sys_string_conversions.h (right): http://codereview.chromium.org/10818016/diff/1/base/sys_string_conversions.h#newcode65 base/sys_string_conversions.h:65: BASE_EXPORT CFStringRef SysWideToCFStringRef(const std::wstring& wide); Is this one used?
8 years, 5 months ago (2012-07-24 16:35:28 UTC) #2
groby-ooo-7-16
http://codereview.chromium.org/10818016/diff/1/base/sys_string_conversions.h File base/sys_string_conversions.h (right): http://codereview.chromium.org/10818016/diff/1/base/sys_string_conversions.h#newcode65 base/sys_string_conversions.h:65: BASE_EXPORT CFStringRef SysWideToCFStringRef(const std::wstring& wide); No, and neither are ...
8 years, 4 months ago (2012-07-31 02:00:14 UTC) #3
Mark Mentovai
http://codereview.chromium.org/10818016/diff/5001/base/sys_string_conversions_mac.mm File base/sys_string_conversions_mac.mm (right): http://codereview.chromium.org/10818016/diff/5001/base/sys_string_conversions_mac.mm#newcode155 base/sys_string_conversions_mac.mm:155: CFStringRef SysWideToCFStringRef(const std::wstring& wide) { You removed this from ...
8 years, 4 months ago (2012-07-31 23:18:24 UTC) #4
groby-ooo-7-16
Third time's the charm. I hope.
8 years, 4 months ago (2012-08-03 21:55:09 UTC) #5
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-03 22:00:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10818016/11001
8 years, 4 months ago (2012-08-03 22:01:24 UTC) #7
commit-bot: I haz the power
Try job failure for 10818016-11001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-03 22:15:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10818016/11001
8 years, 4 months ago (2012-08-03 23:23:34 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 02:28:38 UTC) #10
Change committed as 150002

Powered by Google App Engine
This is Rietveld 408576698