Issue 10816039: Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPL…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10816039: Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPL… (Closed)

Created:
8 years, 5 months ago by Yaron

Modified:
8 years, 5 months ago

Reviewers:
Yaron

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPLEMENTED()s from official builds. Includes: 1) Allowing overridding of android_ndk_sysroot (addition of "%" in variable name). 2) Disable NOTIMPLEMENTED output for official builds (see base/logging.h) 3) Add clang build configurations 4) Remove unnecessary cflags from regular build. 5) Include crtbegin_so.o and crtend_so.so for _type=="loadable_module" which is needed for ppapi_tests. BUG=137569 Review URL: https://chromiumcodereview.appspot.com/10808042 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148147

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -91 lines)			Patch
	M	base/logging.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	build/common.gypi	View		9 chunks	+22 lines, -87 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages