alternate ntp: toolbar background and separator animation

chrome/browser/ui/search/search_tab_helper.h

Index: chrome/browser/ui/search/search_tab_helper.h
diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h
index 4cad6a740c7b75539e3145e7940f5f3827046072..10e421de5a3cda7f573b053594cb5af65999d5e0 100644
--- a/chrome/browser/ui/search/search_tab_helper.h
+++ b/chrome/browser/ui/search/search_tab_helper.h
@@ -41,11 +41,6 @@ class SearchTabHelper : public content::WebContentsObserver,
   // affect the search mode.
   void OmniboxEditModelChanged(OmniboxEditModel* edit_model);
 
-  // content::WebContentsObserver overrides:
-  virtual void NavigateToPendingEntry(
-      const GURL& url,
-      content::NavigationController::ReloadType reload_type) OVERRIDE;
-
   // Overridden from content::NotificationObserver:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
@@ -53,7 +48,8 @@ class SearchTabHelper : public content::WebContentsObserver,
 
  private:
   // Sets the mode of the model based on |url|.
-  void UpdateModel(const GURL& url);
+  // |animate| is flag in model's mode.

[sky, 2012/08/03 22:18:41]

|animate| is set in the Mode passed to the model.

[kuan, 2012/08/13 20:19:46]

Done.

+  void UpdateModel(const GURL& url, bool animate);
 
   // On navigation away from NTP and Search pages, delete |ntp_web_contents_|.
   void FlushNTP(const GURL& url);
@@ -66,6 +62,9 @@ class SearchTabHelper : public content::WebContentsObserver,
   // Lazily created web contents for NTP.
   scoped_ptr<content::WebContents> ntp_web_contents_;
 
+  // True if at least one navigation entry has been committed.
+  bool has_navigated_;

[sky, 2012/08/03 17:29:40]

Can you query the navigation stack rather than maintaining a field?

[kuan, 2012/08/03 17:46:49]

Initially, when we would update mode in NavigateToPendingEntry,
NavigationController::IsInitialNavigation provided what i need - returns true
for the very first URL in any tab.
now that i've removed NavigateToPendingEntry and only update mode on receipt of
NOTIFICATION_NAV_ENTRY_COMMITTED, IsInitialNavigation unfortunately returns
false by then.
i can't find anything else in NavigationController that would indicate the very
first URL in any tab by the time NAV_ENTRY_COMMITTED is received.

[kuan, 2012/08/13 20:19:46]

i've reverted to use NavigateToPendingEntry and
NavigationController::IsInitialNavigation, 'cos dhollowa will be modifying the
code to sometimes update mode for pending entries and sometimes for committed
entries; i've left a TODO for him to handle the cases properly then.

+
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchTabHelper);