alternate ntp: toolbar background and separator animation

chrome/browser/ui/search/search_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_DELEGATE_H_
 #define CHROME_BROWSER_UI_SEARCH_SEARCH_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/ui/search/search_model_observer.h"
@@ skipping 11 matching lines @@
 // SearchModel through to the toolbar, tabstrip and other UI
 // observers.
 // Changes are propagated from the active tab's model via this class to the
 // Browser-level model.
 class SearchDelegate : public SearchModelObserver {
  public:
   explicit SearchDelegate(SearchModel* model);
   virtual ~SearchDelegate();
 
   // Overrides for SearchModelObserver:
-  virtual void ModeChanged(const Mode& mode) OVERRIDE;
+  virtual void ModeChanged(const Mode& old_mode, const Mode& new_mode) OVERRIDE;

[sky, 2012/08/03 17:29:40]

Would be nice if you did this in a separate change to make for a smaller review.

[kuan, 2012/08/03 17:46:49]

i'm sorry abt that :(
this cl, and its original intention, went through so many transformations and
metamorphoses, that modifying ModeChanged API wasn't even the original
intention, it just evolved as the way to fix the mode transition bug :( 

 
   // When the active tab is changed, the model state of this new active tab is
   // propagated to the browser.
   void OnTabActivated(TabContents* contents);
 
   // When a tab is deactivated, this class no longer observes changes to the
   // tab's model.
   void OnTabDeactivated(TabContents* contents);
 
   // When a tab is detached, this class no longer observes changes to the
@@ skipping 20 matching lines @@
   // NTP to SEARCH.
   ToolbarSearchAnimator toolbar_search_animator_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchDelegate);
 };
 
 }  // namespace search
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_SEARCH_SEARCH_DELEGATE_H_