Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Unified Diff: chrome/browser/history/android/favicon_sql_handler.cc

Issue 10815068: Changes favicon database to support storing bitmaps of different sizes for the same icon_url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as per Sky's suggestions on Aug 1 Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.cc » ('j') | chrome/browser/history/history_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/favicon_sql_handler.cc
diff --git a/chrome/browser/history/android/favicon_sql_handler.cc b/chrome/browser/history/android/favicon_sql_handler.cc
index b52aef421d29f906d1d53f17511928bf7506d07d..02ba83ccd0fd86bbf4acba805b41501ce3d733d1 100644
--- a/chrome/browser/history/android/favicon_sql_handler.cc
+++ b/chrome/browser/history/android/favicon_sql_handler.cc
@@ -41,7 +41,7 @@ bool FaviconSQLHandler::Update(const HistoryAndBookmarkRow& row,
scoped_refptr<base::RefCountedMemory> image_data =
new base::RefCountedBytes(row.favicon());
- if (!thumbnail_db_->SetFavicon(favicon_id, image_data, Time::Now()))
+ if (!thumbnail_db_->AddFaviconFrame(favicon_id, image_data, Time::Now()))
return false;
}
@@ -117,7 +117,7 @@ bool FaviconSQLHandler::Insert(HistoryAndBookmarkRow* row) {
scoped_refptr<base::RefCountedMemory> image_data =
new base::RefCountedBytes(row->favicon());
- if (!thumbnail_db_->SetFavicon(id, image_data, Time::Now()))
+ if (!thumbnail_db_->AddFaviconFrame(id, image_data, Time::Now()))
return false;
return thumbnail_db_->AddIconMapping(row->url(), id);
}
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.cc » ('j') | chrome/browser/history/history_backend.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698