chrome/browser/history/expire_history_backend_unittest.cc - Issue 10815068: Changes favicon database to support storing bitmaps of different sizes for the same icon_url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 10815068: Changes favicon database to support storing bitmaps of different sizes for the same icon_url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved some of the android stuff to 10831341 Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/favicon_sql_handler.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | chrome/browser/history/history_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/expire_history_backend_unittest.cc

diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc

index 2cf7385c1a0cf088991c361a461d6d10ffda9f05..ea37d72da5adda586368630c7a2db068cd9a138c 100644

--- a/chrome/browser/history/expire_history_backend_unittest.cc

+++ b/chrome/browser/history/expire_history_backend_unittest.cc

@@ -320,7 +320,7 @@ bool ExpireHistoryTest::HasFavicon(FaviconID favicon_id) {

if (!thumb_db_.get() || favicon_id == 0)

return false;

Time last_updated;

- std::vector<unsigned char> icon_data_unused;

+ scoped_refptr<base::RefCountedMemory> icon_data_unused;

GURL icon_url;

return thumb_db_->GetFavicon(favicon_id, &last_updated, &icon_data_unused,

&icon_url, NULL);