gdata: Check entry_proto.get() before calling has_file_specific_info()

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 1799 matching lines @@
       Bind(&GetGDataFilePropertiesFunction::GetNextFileProperties, this));
 }
 
 void GetGDataFilePropertiesFunction::OnGetFileInfo(
     const FilePath& file_path,
     base::DictionaryValue* property_dict,
     gdata::GDataFileError error,
     scoped_ptr<gdata::GDataEntryProto> entry_proto) {
   DCHECK(property_dict);
 
-  if (!entry_proto->has_file_specific_info())
+  if (entry_proto.get() && !entry_proto->has_file_specific_info())

[achuithb, 2012/07/23 18:52:23]

Is this logic correct?

Shouldn't it be:
if (!entry_proto.get() || !entry_proto->has_file_specific_info())

Same everywhere.

[satorux1, 2012/07/23 19:25:34]

this logic is correct. if entry_proto.get() is null, |error| should be set
properly to something other than OK

     error = gdata::GDATA_FILE_ERROR_NOT_FOUND;
 
   if (error == gdata::GDATA_FILE_OK)
     DoOperation(file_path, property_dict, entry_proto.Pass());
   else
     OnOperationComplete(file_path, property_dict, error, entry_proto.Pass());
 }
 
 void GetGDataFilePropertiesFunction::OnOperationComplete(
     const FilePath& file_path,
     base::DictionaryValue* property_dict,
     gdata::GDataFileError error,
     scoped_ptr<gdata::GDataEntryProto> entry_proto) {
-  if (!entry_proto->has_file_specific_info())
+  if (entry_proto.get() && !entry_proto->has_file_specific_info())
     error = gdata::GDATA_FILE_ERROR_NOT_FOUND;
 
   if (error != gdata::GDATA_FILE_OK) {
     property_dict->SetInteger("errorCode", error);
     CompleteGetFileProperties();
     return;
   }
   DCHECK(entry_proto.get());
 
   const gdata::GDataFileSpecificInfo& file_specific_info =
@@ skipping 559 matching lines @@
   gdata::GDataSystemService* system_service =
       gdata::GDataSystemServiceFactory::GetForProfile(profile_);
   if (!system_service || !system_service->file_system())
     return false;
 
   FilePath directory_path = GetVirtualPathFromURL(GURL(file_url_as_string));
   system_service->file_system()->RequestDirectoryRefresh(directory_path);
 
   return true;
 }