Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 10815039: Make use of -lppapi explicit to allow for correct library order. (Closed)

Created:
8 years, 5 months ago by noelallen1
Modified:
8 years, 5 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make use of -lppapi explicit to allow for correct library order. This CL removes the implicit -lppapi and pthread in the Makefiles. Since ppapi lib does not exist on the host (on NaCl it's actually a linker script), we need to create a bogus ppapi.lib for host Pepper development. In addition, on Windows we do not have a pthread library so we create a mini pthread library to support the examples. This CL also fixes tries which are broken on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148006

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 7

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -29 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M native_client_sdk/src/examples/debugging/example.dsc View 1 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/dlopen/example.dsc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/file_histogram/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_io/example.dsc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/example.dsc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/gamepad/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/geturl/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world/example.dsc View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_gles/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_interactive/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/input_events/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/load_progress/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/mouselock/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/multithreaded_input_events/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pi_generator/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pong/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/sine_synth/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tumbler/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/websocket/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
A native_client_sdk/src/libraries/ppapi/library.dsc View 1 1 chunk +15 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/ppapi/ppapi_externs.c View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/pthread/library.dsc View 1 1 chunk +16 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/pthread/pthread.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/pthread/pthread.c View 1 2 3 4 5 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
8 years, 5 months ago (2012-07-20 23:42:16 UTC) #1
noelallen1
8 years, 5 months ago (2012-07-23 18:45:08 UTC) #2
binji
lgtm http://codereview.chromium.org/10815039/diff/15001/native_client_sdk/src/examples/file_io/example.dsc File native_client_sdk/src/examples/file_io/example.dsc (right): http://codereview.chromium.org/10815039/diff/15001/native_client_sdk/src/examples/file_io/example.dsc#newcode2 native_client_sdk/src/examples/file_io/example.dsc:2: 'TOOLS': ['newlib', 'glibc', 'pnacl'], Is this broken on ...
8 years, 5 months ago (2012-07-23 18:47:14 UTC) #3
noelallen1
http://codereview.chromium.org/10815039/diff/15001/native_client_sdk/src/examples/file_io/example.dsc File native_client_sdk/src/examples/file_io/example.dsc (right): http://codereview.chromium.org/10815039/diff/15001/native_client_sdk/src/examples/file_io/example.dsc#newcode2 native_client_sdk/src/examples/file_io/example.dsc:2: 'TOOLS': ['newlib', 'glibc', 'pnacl'], Yeah, for stuff not checked ...
8 years, 5 months ago (2012-07-23 21:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10815039/8004
8 years, 5 months ago (2012-07-23 22:55:11 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 00:38:06 UTC) #6
Change committed as 148006

Powered by Google App Engine
This is Rietveld 408576698