chrome/common/extensions/permissions/permission_set.h - Issue 10815028: Make ActiveTabPermissionManager also grant the tabs permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set.h

Issue 10815028: Make ActiveTabPermissionManager also grant the tabs permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: oops Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/permission_set.h

diff --git a/chrome/common/extensions/permissions/permission_set.h b/chrome/common/extensions/permissions/permission_set.h

index 4068a2f3fb4cf2b9c68bdd8c721fcba12317543b..76d652138f81e1b45150d5664499255a6a8ad3a0 100644

--- a/chrome/common/extensions/permissions/permission_set.h

+++ b/chrome/common/extensions/permissions/permission_set.h

@@ -70,7 +70,6 @@ class PermissionSet

// Gets the API permissions in this set, plus any that have implicit access

// (such as APIs that require no permissions, or APIs with functions that

// require no permissions).

- // TODO(kalman): return scoped_ptr to avoid copying.

std::set<std::string> GetAPIsWithAnyAccessAsStrings() const;

// Returns whether this namespace has any functions which the extension has