[Chromoting] Fix unit test warnings introduced in r146455.

[Chromoting] Fix unit test warnings introduced in r146455.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148018

[simonmorris, 2012-07-20 00:37:56]

ptal

[Sergey Ulanov, 2012-07-23 21:44:26]

LGTM, but see my comment. Thanks for fixing it.

http://codereview.chromium.org/10815023/diff/1/remoting/protocol/jingle_sessi...
File remoting/protocol/jingle_session_unittest.cc (right):

http://codereview.chromium.org/10815023/diff/1/remoting/protocol/jingle_sessi...
remoting/protocol/jingle_session_unittest.cc:201: .Times(AtMost(1));
It might be flaky with AtMost(1). It should be AtLeast(1) instead.

[simonmorris, 2012-07-23 22:00:05]

How does this look?

http://codereview.chromium.org/10815023/diff/1/remoting/protocol/jingle_sessi...
File remoting/protocol/jingle_session_unittest.cc (right):

http://codereview.chromium.org/10815023/diff/1/remoting/protocol/jingle_sessi...
remoting/protocol/jingle_session_unittest.cc:201: .Times(AtMost(1));
On 2012/07/23 21:44:26, sergeyu wrote:
> It might be flaky with AtMost(1). It should be AtLeast(1) instead.

That makes the Connect* tests fail. I've removed this expectation for those
tests.

[Sergey Ulanov, 2012-07-23 22:05:37]

http://codereview.chromium.org/10815023/diff/4002/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session_unittest.cc (right):

http://codereview.chromium.org/10815023/diff/4002/remoting/protocol/jingle_se...
remoting/protocol/jingle_session_unittest.cc:200: if
(expect_session_route_change) {
It's better to put this in CreateChannel() as we expect this callback only when
we create at least one channel.
And you probably need to copy them in TestFailedChannelAuth as it creates a
channel but doesn't call CreateChannel()

[simonmorris, 2012-07-23 22:21:25]

ptal

http://codereview.chromium.org/10815023/diff/4002/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session_unittest.cc (right):

http://codereview.chromium.org/10815023/diff/4002/remoting/protocol/jingle_se...
remoting/protocol/jingle_session_unittest.cc:200: if
(expect_session_route_change) {
On 2012/07/23 22:05:37, sergeyu wrote:
> It's better to put this in CreateChannel() as we expect this callback only
when
> we create at least one channel.
> And you probably need to copy them in TestFailedChannelAuth as it creates a
> channel but doesn't call CreateChannel()

Done.

[Sergey Ulanov, 2012-07-23 23:37:17]

LGTM. Thanks!

[commit-bot: I haz the power, 2012-07-23 23:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10815023/9001

[commit-bot: I haz the power, 2012-07-24 01:12:46]

Change committed as 148018