gpu/command_buffer/service/program_manager.cc - Issue 10812002: Bug fixes for getTranslatedShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 10812002: Bug fixes for getTranslatedShader (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: last fixes Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/program_manager.cc

diff --git a/gpu/command_buffer/service/program_manager.cc b/gpu/command_buffer/service/program_manager.cc

index c73cab4cd70d1caef6206b993f93117237ab0905..f0c9141e6d5353a261aacacb2d17bb3878a703ba 100644

--- a/gpu/command_buffer/service/program_manager.cc

+++ b/gpu/command_buffer/service/program_manager.cc

@@ -489,7 +489,8 @@ bool ProgramManager::ProgramInfo::Link(ShaderManager* manager,

const int kShaders = ProgramManager::ProgramInfo::kMaxAttachedShaders;

for (int i = 0; i < kShaders; ++i) {

ShaderManager::ShaderInfo* info = attached_shaders_[i].get();

- if (!info->source_compiled()) {

+ if (info->compilation_status() ==

+ ShaderManager::ShaderInfo::PENDING_DEFERRED_COMPILE) {

ShaderTranslator* translator = ShaderIndexToTranslator(

vertex_translator,