Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: src/codegen.h

Issue 1081010: Use bit fields to calculate compare stub minor key (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 private: 354 private:
355 Condition cc_; 355 Condition cc_;
356 bool strict_; 356 bool strict_;
357 // Only used for 'equal' comparisons. Tells the stub that we already know 357 // Only used for 'equal' comparisons. Tells the stub that we already know
358 // that at least one side of the comparison is not NaN. This allows the 358 // that at least one side of the comparison is not NaN. This allows the
359 // stub to use object identity in the positive case. We ignore it when 359 // stub to use object identity in the positive case. We ignore it when
360 // generating the minor key for other comparisons to avoid creating more 360 // generating the minor key for other comparisons to avoid creating more
361 // stubs. 361 // stubs.
362 bool never_nan_nan_; 362 bool never_nan_nan_;
363 363
364 // Encoding of the minor key CCCCCCCCCCCCCCNS.
365 class StrictField: public BitField<bool, 0, 1> {};
366 class NeverNanNanField: public BitField<bool, 1, 1> {};
367 class ConditionField: public BitField<int, 2, 14> {};
368
364 Major MajorKey() { return Compare; } 369 Major MajorKey() { return Compare; }
365 370
366 int MinorKey(); 371 int MinorKey();
367 372
368 // Branch to the label if the given object isn't a symbol. 373 // Branch to the label if the given object isn't a symbol.
369 void BranchIfNonSymbol(MacroAssembler* masm, 374 void BranchIfNonSymbol(MacroAssembler* masm,
370 Label* label, 375 Label* label,
371 Register object, 376 Register object,
372 Register scratch); 377 Register scratch);
373 378
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 private: 587 private:
583 Major MajorKey() { return ToBoolean; } 588 Major MajorKey() { return ToBoolean; }
584 int MinorKey() { return 0; } 589 int MinorKey() { return 0; }
585 }; 590 };
586 591
587 592
588 } // namespace internal 593 } // namespace internal
589 } // namespace v8 594 } // namespace v8
590 595
591 #endif // V8_CODEGEN_H_ 596 #endif // V8_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698