When testing, we don't want to know about 'component' or 'external'...

When testing, we don't want to know about 'component' or 'external'
extensions, and if there are loaded extensions we probably loaded them
explicitly (and got a notification thereof) so don't list them either.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42189

[Paweł Hajdan Jr., 2010-03-19 19:42:18]

Drive-by.

http://codereview.chromium.org/1081008/diff/1/2
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/1081008/diff/1/2#newcode1167
chrome/test/automation/automation_messages_internal.h:1167: // the equivalent of
dropping a .crx file on Chrome).
I'm confused by this comment. Isn't dropping a .crx file on Chrome a valid way
of installing an extension? Could you mean the comment more clear (possibly link
to some doc or more explanation)?

[Jói, 2010-03-19 20:04:15]

http://codereview.chromium.org/1081008/diff/1/2
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/1081008/diff/1/2#newcode1167
chrome/test/automation/automation_messages_internal.h:1167: // the equivalent of
dropping a .crx file on Chrome).
On 2010/03/19 19:42:18, Paweł Hajdan Jr. wrote:
> I'm confused by this comment. Isn't dropping a .crx file on Chrome a valid way
> of installing an extension? Could you mean the comment more clear (possibly
link
> to some doc or more explanation)?

Thanks, you're right it wasn't clear enough.  Changed to:


  // Retrieves a list of the root directories of all enabled extensions
  // that have been installed into Chrome by dropping a .crx file onto 
  // Chrome or an equivalent action.  Other types of extensions are not 
  // included on the list (e.g. "component" extensions, "external" 
  // extensions or extensions loaded via --load-extension since the first
  // two are generally not useful for testing (e.g. an external extension
  // could mess with an automated test if it's present on some systems only)
  // and the last would generally be explicitly loaded by tests.

[MAD, 2010-03-19 20:21:38]

LGTM!

Thanks!

BYE
MAD

[Paweł Hajdan Jr., 2010-03-19 20:46:56]

LGTM