Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1081008: When testing, we don't want to know about 'component' or 'external'... (Closed)

Created:
10 years, 9 months ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
MAD, Paweł Hajdan Jr.
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

When testing, we don't want to know about 'component' or 'external' extensions, and if there are loaded extensions we probably loaded them explicitly (and got a notification thereof) so don't list them either. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42189

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
10 years, 9 months ago (2010-03-19 19:39:04 UTC) #1
Paweł Hajdan Jr.
Drive-by. http://codereview.chromium.org/1081008/diff/1/2 File chrome/test/automation/automation_messages_internal.h (right): http://codereview.chromium.org/1081008/diff/1/2#newcode1167 chrome/test/automation/automation_messages_internal.h:1167: // the equivalent of dropping a .crx file ...
10 years, 9 months ago (2010-03-19 19:42:18 UTC) #2
Jói
http://codereview.chromium.org/1081008/diff/1/2 File chrome/test/automation/automation_messages_internal.h (right): http://codereview.chromium.org/1081008/diff/1/2#newcode1167 chrome/test/automation/automation_messages_internal.h:1167: // the equivalent of dropping a .crx file on ...
10 years, 9 months ago (2010-03-19 20:04:15 UTC) #3
MAD
LGTM! Thanks! BYE MAD
10 years, 9 months ago (2010-03-19 20:21:38 UTC) #4
Paweł Hajdan Jr.
10 years, 9 months ago (2010-03-19 20:46:56 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698